pkg/operator: clarify MCO images and use better names #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
Member
Author
|
/hold we'll get back to this asap |
openshift-ci-robot
added
do-not-merge/hold
Contributor
|
I love this and it would have save be so much time and staring at open tabs.. ❤️ |
Contributor
|
🙏🙏🙏 |
Member
Author
|
/hold cancel rebased and hopefully fixed |
openshift-ci-robot
removed
do-not-merge/hold
Member
Author
|
/retest |
Member
Author
|
ready and green now |
Honestly finding images in the struct confusing as it's really the collection of two different sets of images (renderConfig and ControllerConfig). This also led to some hassles around changing images in openshift#899 for instance. This patch adds some comments around the scope of the images, split the set in two different ones (still tied to the original struct) and change the template keys used to substite.
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly finding images in the struct confusing as it's really the
collection of two different sets of images (renderConfig and
ControllerConfig).
This also led to some hassles around changing images in #899 for
instance.
This patch adds some comments around the scope of the images, split the
set in two different ones (still tied to the original struct) and change
the template keys used to substite.