API Updates

[LorbusChris]

Various API Updates as suggested in and in preparation for openshift/api#301

Added KubeletConfiguration to RawExtension conversion to make API independent from kubelet type/api versioning.

[kikisdeliveryservice]

I know this is a WIP but before you get too far, can you break out those vendor changes as a separate commit?

[kikisdeliveryservice]

uhohs. your e2e-aws-op is hitting the same hyperkube error: 1347 runtime.go:69] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference) as my other pr... 😦

#899 (comment)

but it seems to not completely timeout on that and eventually resolve (tho it spends ~30 mins in that error loop?) see:

Jul 01 19:13:32 ip-10-0-8-233 hyperkube[1347]: I0701 19:13:32.428893    1347 kubelet_node_status.go:283] Setting node annotation to enable volume controller attach/detach
Jul 01 19:13:32 ip-10-0-8-233 hyperkube[1347]: I0701 19:13:32.432759    1347 kubelet_node_status.go:468] Recording NodeHasSufficientMemory event message for node ip-10-0-8-233
Jul 01 19:13:32 ip-10-0-8-233 hyperkube[1347]: I0701 19:13:32.432981    1347 kubelet_node_status.go:468] Recording NodeHasNoDiskPressure event message for node ip-10-0-8-233```

[LorbusChris]

@rphillips could you review the second commit especially. Want to make sure it's ok to encode to JSON internally here instead of YAML.

@sttts please have a look at the KubeletConfiguration<->RawExtension conversion in the third commit. Note that I am re-using and not adding the actual conversion funcs.

cc @runcom @cgwalters

[rphillips]

Does this upgrade a config that is already in yaml to json?

edit: Nevermind... We don't read the yaml kubelet config. This should be great.

[rphillips]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LorbusChris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rphillips]

/hold

for @sttts to confirm his comments were addressed.

[runcom]

uhm, too late, @LorbusChris can you make sure you follow up Stephan comments asap?