Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Jul 3, 2019

/hold

do not merge, smoke testing #899

kikisdeliveryservice and others added 2 commits July 2, 2019 17:44
Template & bootstrap.go need to reference the MCO image instead of the
old setupetcdenv image.

Required-for: openshift/installer#1875
Related-to: openshift#850
Related-to: openshift#739 (issue will only close when final installer pr merges)
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@runcom runcom closed this Jul 3, 2019
@runcom runcom deleted the setupetcenv-image branch July 3, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants