Bug 2033536: OpenShift Api update to fix Alibaba CRD validation by kwoodson · Pull Request #2884 · openshift/machine-config-operator

kwoodson · 2021-12-18T03:35:55Z

Fixes Bug 2033536

- What I did
Updated the latest vendor to openshift/api.
Updated the Dockerfile, Dockerfile.rhel7 to go1.17 to fix compiling issues
Updated CRD to fix validation
- How to verify it
Install using an Alibaba cluster

INFO Install complete!                            
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/kwoodson/tmp/alibaba/cluster/auth/kubeconfig' 
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.test.alicloud-dev.devcluster.openshift.com 
INFO Login to the console with user: "kubeadmin", and password: "xxxxxx" 
DEBUG Time elapsed per stage:                      
DEBUG            cluster: 2m44s                    
DEBUG          bootstrap: 1m7s                     
DEBUG Bootstrap Complete: 14m17s                   
DEBUG                API: 3m5s                     
DEBUG  Cluster Operators: 17m27s                   
INFO Time elapsed: 35m41s

- Description for the changelog
OpenShift API updates to fix Alibaba resourceGroupID CRD validation

Also requires openshift/cluster-config-operator/pull/229

openshift-ci · 2021-12-18T03:36:00Z

@kwoodson: This pull request references Bugzilla bug 2033536, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2033536: OpenShift Api update to fix Alibaba CRD validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mtulio · 2021-12-18T03:49:42Z

we need to check if it will not be replaced by auto-generated code or need to update here: https://github.com/openshift/machine-config-operator/blob/master/pkg/operator/assets/bindata.go#L586

kwoodson · 2021-12-18T06:09:19Z

Retested latest changes. Everything looks healthy:

NAME                                 STATUS   ROLES    AGE   VERSION
test-nf84w-master-0                  Ready    master   31m   v1.22.1+6859754
test-nf84w-master-1                  Ready    master   30m   v1.22.1+6859754
test-nf84w-master-2                  Ready    master   32m   v1.22.1+6859754
test-nf84w-worker-us-east-1a-vv5g2   Ready    worker   19m   v1.22.1+6859754
test-nf84w-worker-us-east-1b-qxjsp   Ready    worker   14m   v1.22.1+6859754
test-nf84w-worker-us-east-1b-zx4d2   Ready    worker   14m   v1.22.1+6859754
NAME                                 PHASE     TYPE            REGION	   ZONE         AGE
test-nf84w-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   33m
test-nf84w-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   33m
test-nf84w-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   33m
test-nf84w-worker-us-east-1a-vv5g2   Running   ecs.g6.large    us-east-1   us-east-1a   26m
test-nf84w-worker-us-east-1b-qxjsp   Running   ecs.g6.large    us-east-1   us-east-1b   26m
test-nf84w-worker-us-east-1b-zx4d2   Running   ecs.g6.large    us-east-1   us-east-1b   26m

INFO Install complete!                            
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/kwoodson/tmp/alibaba/cluster/auth/kubeconfig' 
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.test.alicloud-dev.devcluster.openshift.com 
INFO Login to the console with user: "kubeadmin", and password: "xxxxx" 
DEBUG Time elapsed per stage:                      
DEBUG            cluster: 2m52s                    
DEBUG          bootstrap: 1m10s                    
DEBUG Bootstrap Complete: 14m15s                   
DEBUG                API: 3m0s                     
DEBUG  Cluster Operators: 22m27s                   
INFO Time elapsed: 40m49s

kwoodson · 2021-12-18T06:09:43Z

/retest

mtulio · 2021-12-18T16:07:41Z

/retest-required

jianli-wei · 2021-12-20T03:02:07Z

/Lgtm

FYI using slack app "cluster-bot" to "build #2884,openshift/cluster-image-registry-operator#724", we can get successful IPI installation on Alibabacloud (with "credentialsMode: Manual"):
$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.10.0-0.ci.test-2021-12-22-021122-ci-ln-x2b9shk-latest True False 34s Cluster version is 4.10.0-0.ci.test-2021-12-22-021122-ci-ln-x2b9shk-latest

sinnykumari · 2021-12-20T13:59:23Z

Just an FYI, there is an open PR to update Kube and other libs to 1.23 #2880 and move to go 1.17.

kwoodson · 2021-12-20T14:35:04Z

@sinnykumari Thanks, is it possible that #2880 could update to the latest openshift/API commit? We would like to include a recent change to the kubebuilder validation of a field? This commit openshift/api@8779abf is one we would like to include.

kwoodson · 2021-12-20T15:13:20Z

I believe the tests are failing because we need the CI images to move to golang 1.17. I have opened a PR here openshift/release#24783

kwoodson · 2021-12-20T17:19:45Z

/retest

kwoodson · 2021-12-20T18:37:28Z

/test unit

kwoodson · 2021-12-20T18:40:00Z

/test bootstrap-unit

sinnykumari · 2021-12-20T20:37:38Z

~~I will request to co-ordinate with author of PR #2880 and see what works best for both of you.~~

sinnykumari · 2021-12-20T20:39:53Z

About unit and verify test failure, I have already worked earlier with author of PR#2880 to get fixed.
@eggfoobar please co-ordinate with @kwoodson

sinnykumari · 2021-12-20T21:06:24Z

@kwoodson Sorry for the confusion, please ignore my previous comments.
As this is a valid bug, this PR is good to get reviewed and merged without co-ordination with #2880 (comment)

sinnykumari · 2021-12-20T21:08:43Z

You may need to run make go-deps && make update if haven't already done

kikisdeliveryservice · 2021-12-22T03:14:02Z

this upgrade job is just a mess today :(

/test e2e-agnostic-upgrade

wking · 2021-12-22T08:00:43Z

Update run:

: [sig-network] pods should successfully create sandboxes by not timing out | 0s
-- | --
24 failures to create the sandbox

That's currently considered a symptom of rhbz#2025967, so should be unrelated to this PR and safe to /override ci/prow/e2e-agnostic-upgrade.

sinnykumari · 2021-12-22T08:14:32Z

LGTM
/assign @jianli-wei

sinnykumari · 2021-12-22T13:32:26Z

adding lgtm to get required fix in.
/lgtm

openshift-ci · 2021-12-22T13:32:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, kikisdeliveryservice, kwoodson, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kwoodson · 2021-12-22T14:22:10Z

/retest-required

openshift-bot · 2021-12-22T15:22:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

kwoodson · 2021-12-22T16:30:03Z

/retest-required

openshift-bot · 2021-12-22T16:40:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

sinnykumari · 2021-12-22T17:47:27Z

Since agnostic upgrade runs on Azure which is known to be failing due to multiple issues. Checking the upgrade status on gcp
/test e2e-gcp-upgrade

kikisdeliveryservice · 2021-12-22T18:33:43Z

IT PASSED!! 🎆

kikisdeliveryservice · 2021-12-22T18:55:18Z

/skip

openshift-bot · 2021-12-22T19:42:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-22T19:55:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

kikisdeliveryservice · 2021-12-22T20:07:18Z

/skip

kikisdeliveryservice · 2021-12-22T21:22:02Z

UGH now we got a flake in e2e-aws, which already passed 2 times recently.. one more time..

/retest-required

kikisdeliveryservice · 2021-12-22T22:34:02Z

Ok all required tests have now passed! Now please please just merge bot...

Add: Nooo.

kwoodson · 2021-12-22T23:05:38Z

@kikisdeliveryservice Hmmm. I think something is off. The tide summary doesn't look encouraging. It says its still testing e2e-agnostic-upgrade and e2e-gcp-op even though everything has passed? Maybe (as @wking mentioned) override is necessary. WDYT?

kikisdeliveryservice · 2021-12-22T23:42:39Z

@kikisdeliveryservice Hmmm. I think something is off. The tide summary doesn't look encouraging. It says its still testing e2e-agnostic-upgrade and e2e-gcp-op even though everything has passed? Maybe (as @wking mentioned) override is necessary. WDYT?

Yeah, we got unlucky bc tide does sometimes do spontaneous retests.

I'm going to let them finish, then take it from there. This should merge today. 👍

kikisdeliveryservice · 2021-12-23T00:41:40Z

Given that the upgrade job just passed in a previous run and the current run hit a known bug

Overriding the upgrade test to unblock the the urgent BZ this pr addresses.

/override ci/prow/e2e-agnostic-upgrade

openshift-ci · 2021-12-23T00:42:11Z

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

Given that the upgrade job just passed in a previous run and the current run hit a known bug

Overriding the upgrade test to unblock the the urgent BZ this pr addresses.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-23T00:42:12Z

@kwoodson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel7	`62474b0`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-disruptive	`62474b0`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-upgrade-single-node	`62474b0`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-vsphere-upgrade	`62474b0`	link	false	`/test e2e-vsphere-upgrade`
ci/prow/e2e-aws-workers-rhel8	`62474b0`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-gcp-upgrade	`62474b0`	link	false	`/test e2e-gcp-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2021-12-23T00:44:13Z

@kwoodson: All pull requests linked via external trackers have merged:

Bugzilla bug 2033536 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2033536: OpenShift Api update to fix Alibaba CRD validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 18, 2021

openshift-ci Bot requested a review from jianli-wei December 18, 2021 03:36

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2021

openshift-ci Bot requested review from jkyros and mkenigs December 18, 2021 03:36

kwoodson mentioned this pull request Dec 18, 2021

Bug 2033536: vendor: update openshift/api to include alibaba CRD update openshift/cluster-config-operator#229

Merged

kwoodson force-pushed the api_update branch from 9464b04 to 55eabdf Compare December 18, 2021 03:41

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2021

mtulio reviewed Dec 18, 2021

View reviewed changes

kwoodson force-pushed the api_update branch from 55eabdf to 4553228 Compare December 18, 2021 04:01

openshift-ci Bot assigned jianli-wei Dec 20, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021

kwoodson force-pushed the api_update branch from 4553228 to dfb0072 Compare December 20, 2021 14:59

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2021

jianli-wei mentioned this pull request Dec 22, 2021

support alibabacloud oss for image registry openshift/cluster-image-registry-operator#724

Merged

sinnykumari approved these changes Dec 22, 2021

View reviewed changes

sinnykumari mentioned this pull request Dec 22, 2021

Updating ose-machine-config-operator images to be consistent with ART #2828

Closed

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021

kikisdeliveryservice mentioned this pull request Dec 22, 2021

Updating ose-machine-config-operator images to be consistent with ART #2889

Closed

openshift-merge-robot merged commit f8249fc into openshift:master Dec 23, 2021

Conversation

kwoodson commented Dec 18, 2021

Uh oh!

openshift-ci Bot commented Dec 18, 2021

Uh oh!

mtulio Dec 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kwoodson commented Dec 18, 2021

Uh oh!

kwoodson commented Dec 18, 2021

Uh oh!

mtulio commented Dec 18, 2021

Uh oh!

jianli-wei commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinnykumari commented Dec 20, 2021

Uh oh!

kwoodson commented Dec 20, 2021

Uh oh!

kwoodson commented Dec 20, 2021

Uh oh!

kwoodson commented Dec 20, 2021

Uh oh!

kwoodson commented Dec 20, 2021

Uh oh!

kwoodson commented Dec 20, 2021

Uh oh!

sinnykumari commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinnykumari commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinnykumari commented Dec 20, 2021

Uh oh!

sinnykumari commented Dec 20, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021

Uh oh!

wking commented Dec 22, 2021

Uh oh!

sinnykumari commented Dec 22, 2021

Uh oh!

sinnykumari commented Dec 22, 2021

Uh oh!

openshift-ci Bot commented Dec 22, 2021

Uh oh!

kwoodson commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

kwoodson commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

sinnykumari commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

openshift-bot commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwoodson commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 22, 2021

Uh oh!

kikisdeliveryservice commented Dec 23, 2021

mtulio Dec 18, 2021 •

edited

Loading

jianli-wei commented Dec 20, 2021 •

edited

Loading

sinnykumari commented Dec 20, 2021 •

edited

Loading

sinnykumari commented Dec 20, 2021 •

edited

Loading

kikisdeliveryservice commented Dec 22, 2021 •

edited

Loading