Skip to content

Bug 2033536: vendor: update openshift/api to include alibaba CRD update#229

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kwoodson:update_api
Dec 20, 2021
Merged

Bug 2033536: vendor: update openshift/api to include alibaba CRD update#229
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kwoodson:update_api

Conversation

@kwoodson
Copy link
Copy Markdown

@kwoodson kwoodson commented Dec 17, 2021 •
edited
Loading

Updating to the latest openshift/api types.

The latest infrastructure types were updated and need to be brought inline with the installer.

@openshift-ci openshift-ci Bot requested review from mfojtik and tkashem December 17, 2021 20:39
@kwoodson kwoodson changed the title Update to latest openshift/api Bug 2033536: vendor: update openshift/api to include some alibaba infra changes Dec 17, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

@kwoodson: This pull request references Bugzilla bug 2033536, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2033536: vendor: update openshift/api to include some alibaba infra changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jianli-wei December 17, 2021 20:56
@openshift-ci openshift-ci Bot mentioned this pull request Dec 17, 2021
Merged
@kwoodson kwoodson force-pushed the update_api branch 2 times, most recently from 653331e to 159b0a1 Compare December 18, 2021 03:29
@mtulio
Copy link
Copy Markdown

mtulio commented Dec 18, 2021

Cluster running as expected after that update. API update openshift/api#1088
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2021
@kwoodson kwoodson mentioned this pull request Dec 18, 2021
Merged
@kwoodson
Copy link
Copy Markdown
Author

kwoodson commented Dec 18, 2021

Cluster create occurred successfully:

INFO Install complete!                            
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/kwoodson/tmp/alibaba/cluster/auth/kubeconfig' 
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.test.alicloud-dev.devcluster.openshift.com 
INFO Login to the console with user: "kubeadmin", and password: "xxxxxx" 
DEBUG Time elapsed per stage:                      
DEBUG            cluster: 2m44s                    
DEBUG          bootstrap: 1m7s                     
DEBUG Bootstrap Complete: 14m17s                   
DEBUG                API: 3m5s                     
DEBUG  Cluster Operators: 17m27s                   
INFO Time elapsed: 35m41s                         

NAME                                 STATUS   ROLES    AGE   VERSION
test-mdx4k-master-0                  Ready	master   31m   v1.22.1+6859754
test-mdx4k-master-1                  Ready	master   33m   v1.22.1+6859754
test-mdx4k-master-2                  Ready	master   33m   v1.22.1+6859754
test-mdx4k-worker-us-east-1a-vpwl8   Ready    worker   20m   v1.22.1+6859754
test-mdx4k-worker-us-east-1b-89vxk   Ready    worker   20m   v1.22.1+6859754
test-mdx4k-worker-us-east-1b-cs59j   Ready    worker   19m   v1.22.1+6859754
NAME                                 PHASE     TYPE            REGION	   ZONE         AGE
test-mdx4k-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   34m
test-mdx4k-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   34m
test-mdx4k-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   34m
test-mdx4k-worker-us-east-1a-vpwl8   Running   ecs.g6.large    us-east-1   us-east-1a   28m
test-mdx4k-worker-us-east-1b-89vxk   Running   ecs.g6.large    us-east-1   us-east-1b   28m
test-mdx4k-worker-us-east-1b-cs59j   Running   ecs.g6.large    us-east-1   us-east-1b   28m

This also requires openshift/machine-config-operator/pull/2884

@kwoodson
Copy link
Copy Markdown
Author

kwoodson commented Dec 18, 2021

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2021
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 18, 2021

@kwoodson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kwoodson kwoodson changed the title Bug 2033536: vendor: update openshift/api to include some alibaba infra changes Bug 2033536: vendor: update openshift/api to include alibaba CRD update Dec 18, 2021
@kwoodson
Copy link
Copy Markdown
Author

kwoodson commented Dec 18, 2021

Retested latest changes. Everything looks healthy:

NAME                                 STATUS   ROLES    AGE   VERSION
test-nf84w-master-0                  Ready    master   31m   v1.22.1+6859754
test-nf84w-master-1                  Ready    master   30m   v1.22.1+6859754
test-nf84w-master-2                  Ready    master   32m   v1.22.1+6859754
test-nf84w-worker-us-east-1a-vv5g2   Ready    worker   19m   v1.22.1+6859754
test-nf84w-worker-us-east-1b-qxjsp   Ready    worker   14m   v1.22.1+6859754
test-nf84w-worker-us-east-1b-zx4d2   Ready    worker   14m   v1.22.1+6859754
NAME                                 PHASE     TYPE            REGION	   ZONE         AGE
test-nf84w-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   33m
test-nf84w-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   33m
test-nf84w-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   33m
test-nf84w-worker-us-east-1a-vv5g2   Running   ecs.g6.large    us-east-1   us-east-1a   26m
test-nf84w-worker-us-east-1b-qxjsp   Running   ecs.g6.large    us-east-1   us-east-1b   26m
test-nf84w-worker-us-east-1b-zx4d2   Running   ecs.g6.large    us-east-1   us-east-1b   26m

INFO Install complete!                            
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/kwoodson/tmp/alibaba/cluster/auth/kubeconfig' 
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.test.alicloud-dev.devcluster.openshift.com 
INFO Login to the console with user: "kubeadmin", and password: "xxxxx" 
DEBUG Time elapsed per stage:                      
DEBUG            cluster: 2m52s                    
DEBUG          bootstrap: 1m10s                    
DEBUG Bootstrap Complete: 14m15s                   
DEBUG                API: 3m0s                     
DEBUG  Cluster Operators: 22m27s                   
INFO Time elapsed: 40m49s

@tkashem
Copy link
Copy Markdown
Contributor

tkashem commented Dec 18, 2021

/lgtm
/approve

Thanks!

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 18, 2021
@tkashem
Copy link
Copy Markdown
Contributor

tkashem commented Dec 18, 2021

/hold

@soltysh is this safe to merge before the rebase PR openshift/kubernetes#1087 lands?

@jianli-wei
Copy link
Copy Markdown

jianli-wei commented Dec 20, 2021

/Lgtm

soltysh
soltysh approved these changes Dec 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh is this safe to merge before the rebase PR openshift/kubernetes#1087 lands?

No objections

/hold cancel

/lgtm
/approve

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, kwoodson, mtulio, soltysh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5db9cdf into openshift:master Dec 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2021

@kwoodson: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2033536 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2033536: vendor: update openshift/api to include alibaba CRD update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar eggfoobar mentioned this pull request Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@tkashem tkashem Awaiting requested review from tkashem

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@mtulio mtulio

@tkashem tkashem

@jianli-wei jianli-wei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kwoodson @mtulio @tkashem @jianli-wei @soltysh @openshift-merge-robot