Skip to content

Bumping MCO repository to golang 1.17#24783

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kwoodson:mco_to_17
Dec 20, 2021
Merged

Bumping MCO repository to golang 1.17#24783
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kwoodson:mco_to_17

Conversation

@kwoodson
Copy link
Copy Markdown

In order to satisfy a few of the failing tests and to align with the upcoming changes from openshift/api we need to move to golang 1.17.

@kwoodson
Copy link
Copy Markdown
Author

This should help with failing jobs with the following errors:

vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

@sinnykumari
Copy link
Copy Markdown
Contributor

Thanks for the PR. Can you also update go version into openshift-machine-config-operator-release-4.11.yaml and openshift-machine-config-operator-release-4.10.yaml . As, all of them will require them

@kwoodson
Copy link
Copy Markdown
Author

@sinnykumari Sure thing, I have updated. I'm not 100% sure if the image should bump from 4.10 to 4.11 but this mirrors some of the other repositories with keeping it as 4.10.

Copy link
Copy Markdown
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sinnykumari
Copy link
Copy Markdown
Contributor

@sinnykumari Sure thing, I have updated. I'm not 100% sure if the image should bump from 4.10 to 4.11 but this mirrors some of the other repositories with keeping it as 4.10.

It make sense since we won't be having yet any build image for 4.11 until branching

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwoodson, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0ed0b6a into openshift:master Dec 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2021

@kwoodson: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.10.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.10.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.11.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.11.yaml
Details

In response to this:

In order to satisfy a few of the failing tests and to align with the upcoming changes from openshift/api we need to move to golang 1.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants