Bug 2033536: Alibaba infrastructure config: Updating kube validation on optional s…

[kwoodson]

…tring

When testing recently with the recent optional field the validation has been failing when golang defaults the empty string to "". The fix here is to make the string be optionally "".

Dec 17 17:02:54 citest-4zx6j-bootstrap bootkube.sh[2351]: "cluster-infrastructure-02-config.yml": failed to update status for infrastructures.v1.config.openshift.io/cluster -n : Infrastructure.config.openshift.io "cluster" is invalid: status.platformStatus.alibabaCloud.resourceGroupID: Invalid value: "": status.platformStatus.alibabaCloud.resourceGroupID in body should match '^rg-[0-9A-Za-z]+$'

[openshift-ci]

@kwoodson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[deads2k]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, kwoodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kwoodson: This pull request references Bugzilla bug 2033536, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2033536: Alibaba infrastructure config: Updating kube validation on optional s…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kwoodson]

This allows the string to be empty in cases where it gets defaults to "".

[openshift-ci]

@kwoodson: Some pull requests linked via external trackers have merged:

• openshift/api#1088

The following pull requests linked via external trackers have not merged:

• openshift/cluster-config-operator#229 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2033536 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2033536: Alibaba infrastructure config: Updating kube validation on optional s…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianli-wei]

/Lgtm