Skip to content

[release-4.5] Bug 1844092: Remove dns vip #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Jun 7, 2020
Merged

[release-4.5] Bug 1844092: Remove dns vip #1782

openshift-merge-robot merged 3 commits into from
Jun 7, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 4, 2020

This is an automated cherry-pick of #1775

/assign Gal-Zaidman

Gal-Zaidman added 3 commits June 4, 2020 15:34
oVirt: Add NetworkManager-resolv-prepender
0dc620b 
On ocp 4.6 rchos removed dhclient, so we need to decided to move away from using the DNSVIP.
This patch adds NM dispatcher 30-resolv-prepender script to append the nameserver to /etc/resolv.conf.

Signed-off-by: Gal-Zaidman <[email protected]>
oVirt: Remove DNS VIP
9bd5a5d 
This commits follow [1][2] in removing DNS VIP.

Taken from [2]:
"Now that etcd does not need DNS for clustering, we no longer need to
have a VIP to allow the masters to use the bootstrap coredns until
their own coredns instances start. Instead, we can just point them
at the local coredns directly and skip the extra complexity."

[1] openshift#1569
[2] openshift#1666

Signed-off-by: Gal-Zaidman <[email protected]>
update pkg/operator/assets
7631214 
Signed-off-by: Gal-Zaidman <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 4, 2020

@openshift-cherrypick-robot: Bugzilla bug 1843010 has been cloned as Bugzilla bug 1844092. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1844092: Remove dns vip

Details

In response to this:

[release-4.5] Bug 1843010: Remove dns vip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1843010: Remove dns vip [release-4.5] Bug 1844092: Remove dns vip Jun 4, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 4, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1844092, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1843010 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1843010 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

[release-4.5] Bug 1844092: Remove dns vip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link

Gal-Zaidman commented Jun 4, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2020
@Gal-Zaidman
Copy link

Gal-Zaidman commented Jun 4, 2020

/assign @rgolangh

Adding hold until you will review and approve it will not cause side effects to 4.5

@Gal-Zaidman Gal-Zaidman removed their assignment Jun 4, 2020
@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 5, 2020
@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/approve

@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/assign @rgolangh

Adding hold until you will review and approve it will not cause side effects to 4.5

The only effect is that this is a redundant requirement for the installer, and the api.

@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/test e2e-ovirt

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 5, 2020

@rgolangh: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-gcp-op
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-vsphere
  • /test images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws-scaleup-rhel7
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-gcp-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-release-4.5-images
  • pull-ci-openshift-machine-config-operator-release-4.5-unit
  • pull-ci-openshift-machine-config-operator-release-4.5-verify
Details

In response to this:

/test e2e-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/hold
@Gal-Zaidman we are missing 4.5 presubmits - here is a PR for that openshift/release#9500

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/test e2e-ovirt

@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020 •
edited
Loading

/unhold
ovirt e2e presubmit is running

@rgolangh
Copy link
Contributor

rgolangh commented Jun 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

27 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3341f6f into openshift:release-4.5 Jun 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 7, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1782. Bugzilla bug 1844092 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1844092: Remove dns vip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@ericavonb ericavonb Awaiting requested review from ericavonb

Assignees

@rgolangh rgolangh

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @Gal-Zaidman @rgolangh @openshift-bot @yuqi-zhang @sdodson @openshift-merge-robot