Bug 1825948: cloudConfig: read cloud Config from openshift-config-managed/kube-cloud-config ConfigMap #1658

sinnykumari · 2020-04-16T15:29:03Z

cloudConfig is now generated by kube_cloud_config controller for all supported
platforms. Controller generates kube-cloud-config ConfigMap in openshift-config-managed
namespace where cloud.conf key is stored.

Links:

sinnykumari · 2020-04-16T15:39:27Z

/cc sdodson

sinnykumari · 2020-04-16T15:40:05Z

/cc @sdodson

sinnykumari · 2020-04-16T17:32:59Z

/retest

sinnykumari · 2020-04-16T17:48:40Z

/retest

sdodson · 2020-04-16T18:07:55Z

/assign @runcom @abhinavdahiya

sinnykumari · 2020-04-17T06:47:53Z

/skip
/test e2e-gcp-op
/test e2e-gcp-upgrade

runcom · 2020-04-17T08:09:25Z

/retest

pkg/operator/sync.go

sinnykumari · 2020-04-17T11:28:10Z

interesting, since 30 mins jobs are at waiting for importing pipeline:base ...

sinnykumari · 2020-04-17T11:45:21Z

/retest

sinnykumari · 2020-04-17T12:52:57Z

/retest

LorbusChris · 2020-04-17T14:13:39Z

@sinnykumari @runcom this might be a good opportunity to move to using properly typed PlatformType identifiers instead of the untyped strings we're using (and that are already marked as wrong by the TODO comment).

This commit here from another PR migrates the Controller over to use them, it might serve you as a reference: 27502d5

The PlatformType fields already defined in ControllerConfig.Infra.Status.PlatformStatus.Type, it's just that the Controller doesn't process them, and looks up that info in the ControllerConfig.Platform strings instead.

sinnykumari · 2020-04-17T15:48:10Z

/retest

abhinavdahiya · 2020-04-17T18:56:42Z

https://github.com/openshift/api/pull/621/files#diff-cee9360e003319719376a6c9189c2e48R29-R37

so the MCO should be reading from openshift-managed-config/kube-cloud-config configmap cloud.conf key. that's the expectation of the API.

so, therefore, don't look at the spec.cloudConfig.name

so personally this should be

get configmap openshift-managed-config/kube-cloud-config
if err 
    if err is NotFound
        if cloud config required for platform
            return err
use the cloud.conf key to configure the kubelet.

is cloud config required for platform:
if spec.cloudConfig.name != "" return true
if platform in list [] return true
return false

sinnykumari · 2020-04-20T08:00:15Z

Thanks Abhinav for the feedback, made changes accordingly.
Let me know if I missed something :)

sinnykumari · 2020-04-20T15:09:42Z

/bugzilla refresh

openshift-ci-robot · 2020-04-20T15:09:48Z

@sinnykumari: This pull request references Bugzilla bug 1825948, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2020-04-20T19:30:38Z

/skip

sinnykumari · 2020-04-21T12:37:14Z

PR referencing bug https://bugzilla.redhat.com/show_bug.cgi?id=1825944 has been merged.
/retest

sinnykumari · 2020-04-21T14:42:59Z

/retest

LorbusChris · 2020-04-22T17:32:35Z

/retest

LorbusChris · 2020-04-22T23:35:59Z

/test e2e-gcp-op

sinnykumari · 2020-04-23T04:03:11Z

Yay, tests are passing now!

runcom · 2020-04-23T07:48:47Z

@abhinavdahiya ptal

pkg/operator/sync.go

…ud-config ConfigMap cloudConfig is now generated by kube_cloud_config controller for all supported platforms. Controller generates kube-cloud-config ConfigMap in openshift-config-managed namespace where cloud.conf key is stored. Links: - https://github.com/openshift/enhancements/blob/master/enhancements/installer/aws-custom-region-and-endpoints.md - openshift/api#599 - openshift/api#621

pkg/operator/sync.go

openshift-ci-robot · 2020-04-24T12:32:33Z

@sinnykumari: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`e7455dc`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

runcom · 2020-04-24T15:38:33Z

/skip

abhinavdahiya · 2020-04-24T17:50:41Z

/lgtm

openshift-ci-robot · 2020-04-24T17:51:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-24T17:55:34Z

@sinnykumari: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1658. Bugzilla bug 1825948 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1825948: cloudConfig: read cloud Config from openshift-config-managed/kube-cloud-config ConfigMap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Previously the cloud provider config map was sourced from the `.spec.cloudConf` of the infrastructure object. but to enable user input and stitching explained in [1] and [2], we added a controller to generate a cloud configuraration using the spec for use by kubelet and kube cloud controller manager. The new API defined in [3] creates a config map `openshift-config-managed/kube-cloud-config` with the configuration in `cloud.conf` key. We updated the in-cluster MCO to use the new API [4] but the MCO on bootstrap host was left untouched because the controller could not generated on the bootstrap host yet. But [5] and [6] intend to provide the same generated config map on the bootstrap host for MCO, and therefore we need the bootstrap MCO to read the key defined by the generated API but fallback to he spec key (old behavior) for backward compatibility. [1]: https://github.com/openshift/enhancements/blob/master/enhancements/installer/aws-custom-region-and-endpoints.md [2]: https://github.com/openshift/enhancements/blob/master/enhancements/installer/azure-support-known-cloud-environments.md [3]: https://github.com/openshift/api/blob/e21882127f24772e3b5388fe1fdc37669e8e1d04/config/v1/types_infrastructure.go#L26-L40 [4]: openshift#1658 [5]: openshift/cluster-config-operator#140 [6]: openshift/installer#3831

sinnykumari requested review from abhinavdahiya and runcom April 16, 2020 15:29

openshift-ci-robot requested review from ashcrow and yuqi-zhang April 16, 2020 15:29

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020

openshift-ci-robot requested a review from sdodson April 16, 2020 15:39

sinnykumari force-pushed the cloudconfig branch 3 times, most recently from ca365ee to ac77ea8 Compare April 16, 2020 17:05

openshift-ci-robot assigned abhinavdahiya and runcom Apr 16, 2020

runcom reviewed Apr 17, 2020

View reviewed changes

pkg/operator/sync.go Outdated Show resolved Hide resolved

sinnykumari force-pushed the cloudconfig branch 2 times, most recently from cb5a911 to 31799e4 Compare April 17, 2020 09:59

sinnykumari force-pushed the cloudconfig branch from 31799e4 to d154635 Compare April 17, 2020 14:17

sinnykumari force-pushed the cloudconfig branch from d154635 to 0355281 Compare April 20, 2020 07:58

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2020

sinnykumari mentioned this pull request Apr 22, 2020

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers openshift/cluster-config-operator#128

Merged

LorbusChris mentioned this pull request Apr 23, 2020

Deprecate Platform field on ControllerConfig CRD #1624

Merged

abhinavdahiya reviewed Apr 23, 2020

View reviewed changes

pkg/operator/sync.go Outdated Show resolved Hide resolved

abhinavdahiya reviewed Apr 23, 2020

View reviewed changes

pkg/operator/sync.go Outdated Show resolved Hide resolved

abhinavdahiya reviewed Apr 23, 2020

View reviewed changes

pkg/operator/sync.go Outdated Show resolved Hide resolved

sinnykumari force-pushed the cloudconfig branch from d08d02c to e7455dc Compare April 24, 2020 11:10

sinnykumari commented Apr 24, 2020

View reviewed changes

pkg/operator/sync.go Show resolved Hide resolved

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020

openshift-merge-robot merged commit 5230988 into openshift:master Apr 24, 2020

stbenjam mentioned this pull request Apr 27, 2020

Bug 1828106: cloudConfig: remove bare metal from platforms that require a cloud conifg #1685

Merged

abhinavdahiya mentioned this pull request Jul 31, 2020

Bug 1864677: operator/bootstrap: use correct key for generated cloud conf #1973

Merged

Bug 1825948: cloudConfig: read cloud Config from openshift-config-managed/kube-cloud-config ConfigMap #1658

Bug 1825948: cloudConfig: read cloud Config from openshift-config-managed/kube-cloud-config ConfigMap #1658

Uh oh!

Conversation

sinnykumari commented Apr 16, 2020

Uh oh!

sinnykumari commented Apr 16, 2020

Uh oh!

sinnykumari commented Apr 16, 2020

Uh oh!

sinnykumari commented Apr 16, 2020

Uh oh!

sinnykumari commented Apr 16, 2020

Uh oh!

sdodson commented Apr 16, 2020

Uh oh!

sinnykumari commented Apr 17, 2020

Uh oh!

runcom commented Apr 17, 2020

Uh oh!

Uh oh!

sinnykumari commented Apr 17, 2020

Uh oh!

sinnykumari commented Apr 17, 2020

Uh oh!

sinnykumari commented Apr 17, 2020

Uh oh!

LorbusChris commented Apr 17, 2020

Uh oh!

sinnykumari commented Apr 17, 2020

Uh oh!

abhinavdahiya commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinnykumari commented Apr 20, 2020

Uh oh!

sinnykumari commented Apr 20, 2020

Uh oh!

openshift-ci-robot commented Apr 20, 2020

Uh oh!

kikisdeliveryservice commented Apr 20, 2020

Uh oh!

sinnykumari commented Apr 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinnykumari commented Apr 21, 2020

Uh oh!

LorbusChris commented Apr 22, 2020

Uh oh!

LorbusChris commented Apr 22, 2020

Uh oh!

sinnykumari commented Apr 23, 2020

Uh oh!

runcom commented Apr 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 24, 2020

Uh oh!

runcom commented Apr 24, 2020

Uh oh!

abhinavdahiya commented Apr 24, 2020

Uh oh!

openshift-ci-robot commented Apr 24, 2020

Uh oh!

openshift-ci-robot commented Apr 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

abhinavdahiya commented Apr 17, 2020 •

edited

Loading

sinnykumari commented Apr 21, 2020 •

edited

Loading