config/v1/types_infrastructure.go: add kube cloud config to status #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdahiya
force-pushed
the
status_cloud_config
branch
from
e63dedd to
37600d5
Compare
Contributor
|
I expected that we choose a fixed namespace/name tuple with a fixed key in the configmap data. Doing that would remove the need for this new field and give a known location for CEE and all. |
…ine the generated one's location The cloudConfig is generated by the stitching together the user specifed config and the other platform spec in the infrstructure object.
abhinavdahiya
force-pushed
the
status_cloud_config
branch
from
37600d5 to
2dadc74
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
sinnykumari
added a commit
to sinnykumari/machine-config-operator
that referenced
this pull request
Apr 24, 2020
…ud-config ConfigMap cloudConfig is now generated by kube_cloud_config controller for all supported platforms. Controller generates kube-cloud-config ConfigMap in openshift-config-managed namespace where cloud.conf key is stored. Links: - https://github.com/openshift/enhancements/blob/master/enhancements/installer/aws-custom-region-and-endpoints.md - openshift/api#599 - openshift/api#621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #599 please review that first.
The cloudConfig is generated by the stitching together the user specifed config and the other platform spec in the infrstructure object.