Bug 1825944: kube_cloud_config: enforce the target key in config map to cloud.conf #126
Conversation
The infrastructure.config.openshift.io/v1 requires that the key for cloud config in the generated config map be `cloud.conf`. Previously the controller was just copying and not enforcing the target key. no both the as-is and aws transformers enforce this, and also the tests were updated to check that.
|
@abhinavdahiya: This pull request references Bugzilla bug 1825944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
openshift/release#8437 should help run azure, gcp clusters for testing. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/cluster-config-operator#126. Bugzilla bug 1825944 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
The infrastructure.config.openshift.io/v1 requires that the key for cloud config in the generated config map be
cloud.conf.Previously the controller was just copying and not enforcing the target key.
no both the as-is and aws transformers enforce this, and also the tests were updated to check that.