Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers #128

abhinavdahiya · 2020-04-21T16:54:07Z

/test e2e-gcp
/test e2e-azure

openshift-ci-robot · 2020-04-21T16:58:14Z

@abhinavdahiya: This pull request references Bugzilla bug 1825944, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinavdahiya · 2020-04-21T17:00:05Z

/hold

need to make sure gcp, azure work correctly.

abhinavdahiya · 2020-04-21T18:59:41Z

/hold cancel

abhinavdahiya · 2020-04-21T19:01:35Z

/bugzillla refresh

/test e2e-gcp
/test e2e-azure

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/128/pull-ci-openshift-cluster-config-operator-master-e2e-azure/1/artifacts/e2e-azure/configmaps.json

        {
            "apiVersion": "v1",
            "data": {
                "cloud.conf": "{\n\t\"cloud\": \"AzurePublicCloud\",\n\t\"tenantId\": \"6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee\",\n\t\"aadClientId\": \"\",\n\t\"aadClientSecret\": \"\",\n\t\"aadClientCertPath\": \"\",\n\t\"aadClientCertPassword\": \"\",\n\t\"useManagedIdentityExtension\": true,\n\t\"userAssignedIdentityID\": \"\",\n\t\"subscriptionId\": \"d38f1e38-4bed-438e-b227-833f997adf6a\",\n\t\"resourceGroup\": \"ci-op-s3j175fs-371be-mbn5k-rg\",\n\t\"location\": \"eastus2\",\n\t\"vnetName\": \"ci-op-s3j175fs-371be-mbn5k-vnet\",\n\t\"vnetResourceGroup\": \"ci-op-s3j175fs-371be-mbn5k-rg\",\n\t\"subnetName\": \"ci-op-s3j175fs-371be-mbn5k-worker-subnet\",\n\t\"securityGroupName\": \"ci-op-s3j175fs-371be-mbn5k-node-nsg\",\n\t\"routeTableName\": \"ci-op-s3j175fs-371be-mbn5k-node-routetable\",\n\t\"primaryAvailabilitySetName\": \"\",\n\t\"vmType\": \"\",\n\t\"primaryScaleSetName\": \"\",\n\t\"cloudProviderBackoff\": true,\n\t\"cloudProviderBackoffRetries\": 0,\n\t\"cloudProviderBackoffExponent\": 0,\n\t\"cloudProviderBackoffDuration\": 6,\n\t\"cloudProviderBackoffJitter\": 0,\n\t\"cloudProviderRateLimit\": true,\n\t\"cloudProviderRateLimitQPS\": 6,\n\t\"cloudProviderRateLimitBucket\": 10,\n\t\"cloudProviderRateLimitQPSWrite\": 6,\n\t\"cloudProviderRateLimitBucketWrite\": 10,\n\t\"useInstanceMetadata\": true,\n\t\"loadBalancerSku\": \"standard\",\n\t\"excludeMasterFromStandardLB\": null,\n\t\"disableOutboundSNAT\": null,\n\t\"maximumLoadBalancerRuleCount\": 0\n}\n"
            },
            "kind": "ConfigMap",
            "metadata": {
                "creationTimestamp": "2020-04-21T17:41:32Z",
                "managedFields": [
                    {
                        "apiVersion": "v1",
                        "fieldsType": "FieldsV1",
                        "fieldsV1": {
                            "f:data": {
                                ".": {},
                                "f:cloud.conf": {}
                            }
                        },
                        "manager": "cluster-config-operator",
                        "operation": "Update",
                        "time": "2020-04-21T17:41:32Z"
                    }
                ],
                "name": "kube-cloud-config",
                "namespace": "openshift-config-managed",
                "resourceVersion": "14588",
                "selfLink": "/api/v1/namespaces/openshift-config-managed/configmaps/kube-cloud-config",
                "uid": "92bb26b3-7cad-4b45-bbaa-c214fa5ad2c9"
            }
        },

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-config-operator/128/pull-ci-openshift-cluster-config-operator-master-e2e-gcp/1/artifacts/e2e-gcp/configmaps.json

        {
            "apiVersion": "v1",
            "data": {
                "cloud.conf": "[global]\nproject-id      = openshift-gce-devel-ci\nregional        = true\nmultizone       = true\nnode-tags       = ci-op-mjbwr-master\nnode-tags       = ci-op-mjbwr-worker\nnode-instance-prefix = ci-op-mjbwr\nexternal-instance-groups-prefix = ci-op-mjbwr\nsubnetwork-name = ci-op-mjbwr-worker-subnet\n\n"
            },
            "kind": "ConfigMap",
            "metadata": {
                "creationTimestamp": "2020-04-21T17:46:12Z",
                "managedFields": [
                    {
                        "apiVersion": "v1",
                        "fieldsType": "FieldsV1",
                        "fieldsV1": {
                            "f:data": {
                                ".": {},
                                "f:cloud.conf": {}
                            }
                        },
                        "manager": "cluster-config-operator",
                        "operation": "Update",
                        "time": "2020-04-21T17:46:12Z"
                    }
                ],
                "name": "kube-cloud-config",
                "namespace": "openshift-config-managed",
                "resourceVersion": "17524",
                "selfLink": "/api/v1/namespaces/openshift-config-managed/configmaps/kube-cloud-config",
                "uid": "d250e640-4957-4060-905d-94c2a510bf34"
            }
        },

abhinavdahiya · 2020-04-21T19:03:43Z

/test e2e-gcp
/test e2e-azure

abhinavdahiya · 2020-04-21T19:03:53Z

/bugzillla refresh

sinnykumari · 2020-04-22T06:50:21Z

/bugzillla refresh
/retest

sinnykumari · 2020-04-22T09:34:29Z

Using clusterbot checked-

cluster install succeeded with this PR and Bug 1825948: cloudConfig: read cloud Config from openshift-config-managed/kube-cloud-config ConfigMap machine-config-operator#1658
upgrade from 4.5 to this PR + Bug 1825948: cloudConfig: read cloud Config from openshift-config-managed/kube-cloud-config ConfigMap machine-config-operator#1658 went well

LorbusChris · 2020-04-22T12:16:43Z

/test e2e-azure

deads2k · 2020-04-22T14:43:41Z

/lgtm

but you're still not quite green.

openshift-ci-robot · 2020-04-22T14:44:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-22T14:51:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-22T15:31:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-22T16:40:45Z

@abhinavdahiya: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure	`ab3da4f`	link	`/test e2e-azure`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LorbusChris · 2020-04-22T16:47:14Z

/test e2e-azure

openshift-bot · 2020-04-22T16:48:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

abhinavdahiya · 2020-04-22T16:52:04Z

/bugzillla refresh

hongkailiu · 2020-04-22T17:20:07Z

/bugzilla refresh

openshift-ci-robot · 2020-04-22T17:20:11Z

@hongkailiu: This pull request references Bugzilla bug 1825944, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-22T17:24:28Z

@abhinavdahiya: All pull requests linked via external trackers have merged: openshift/cluster-config-operator#126, openshift/cluster-config-operator#128. Bugzilla bug 1825944 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kube_cloud_config: pass correct sourcekey to the transformers

d01cc06

openshift-ci-robot added bugzilla/medium bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 21, 2020

openshift-ci-robot requested review from jstuever and patrickdillon April 21, 2020 17:00

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020

kube_cloud_config: add unit test for sync

fbdad2e

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020

vendor: bump

ab3da4f

openshift-ci-robot assigned deads2k Apr 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 22, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2020

openshift-merge-robot merged commit 088dc50 into openshift:master Apr 22, 2020

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers #128

Bug 1825944: kube_cloud_config: pass correct sourcekey to the transformers #128

Uh oh!

Conversation

abhinavdahiya commented Apr 21, 2020

Uh oh!

openshift-ci-robot commented Apr 21, 2020

Uh oh!

abhinavdahiya commented Apr 21, 2020

Uh oh!

abhinavdahiya commented Apr 21, 2020

Uh oh!

abhinavdahiya commented Apr 21, 2020

Uh oh!

abhinavdahiya commented Apr 21, 2020

Uh oh!

abhinavdahiya commented Apr 21, 2020

Uh oh!

sinnykumari commented Apr 22, 2020

Uh oh!

sinnykumari commented Apr 22, 2020

Uh oh!

LorbusChris commented Apr 22, 2020

Uh oh!

deads2k commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

openshift-bot commented Apr 22, 2020

Uh oh!

openshift-bot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

LorbusChris commented Apr 22, 2020

Uh oh!

openshift-bot commented Apr 22, 2020

Uh oh!

abhinavdahiya commented Apr 22, 2020

Uh oh!

hongkailiu commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants