-
Notifications
You must be signed in to change notification settings - Fork 462
Bug 1737120: fold images: remove stale refs to mc* images in install/image-references #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1737120: fold images: remove stale refs to mc* images in install/image-references #1028
Conversation
This is the 3rd pr in a series to fold all MC* images into one. PR does the following as step 3: - update dockerfile.machine-config-operator to generates all component images (mco/mcc/mcd/mcs/setup-etc-env) - update dockerfile.machine-config-operator.rhel7 the same as sbove - update image-references, configmap and manifests to use MCO image - update MCO image flag in bootstrap.go to be required Related-to: #847 (merged) Requires: openshift/installer#1847 (merged) Related-to: #739 (issue will only close when final installer pr merges)
Update install/image-references to remove stale references to non-mco images. And remove my to-do. Note: this is required for multi-arch team work. Related-to: openshift#739
a64566c to
84ea777
Compare
|
/test e2e-aws-op |
1 similar comment
|
/test e2e-aws-op |
|
This fixes the issues we were seeing. |
|
PTAL: @runcom |
|
/approve filing a BZ as per process to get this in asap, great catch! |
|
@kikisdeliveryservice: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kikisdeliveryservice: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update install/image-references to remove stale references to non-mco images. And remove my to-do.
Note: this is required for multi-arch team work. cc: @yselkowitz
Related-to: #739