Skip to content

Conversation

@kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Aug 1, 2019

Update install/image-references to remove stale references to non-mco images. And remove my to-do.

Note: this is required for multi-arch team work. cc: @yselkowitz

Related-to: #739

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 1, 2019
@kikisdeliveryservice kikisdeliveryservice removed the request for review from ashcrow August 1, 2019 19:26
kikisdeliveryservice referenced this pull request Aug 1, 2019
This is the 3rd pr in a series to fold all MC* images into one.
PR does the following as step 3:
- update dockerfile.machine-config-operator to generates all component
images (mco/mcc/mcd/mcs/setup-etc-env)
- update dockerfile.machine-config-operator.rhel7 the same as sbove
- update image-references, configmap and manifests to use MCO image
- update MCO image flag in bootstrap.go to be required

Related-to: #847 (merged)
Requires: openshift/installer#1847 (merged)
Related-to: #739 (issue will only close when final installer pr merges)
Update install/image-references to remove stale references to non-mco images. And remove my to-do.

Note: this is required for multi-arch team work.

Related-to: openshift#739
@kikisdeliveryservice kikisdeliveryservice force-pushed the remove-stale-install-image-refs branch from a64566c to 84ea777 Compare August 1, 2019 19:34
@kikisdeliveryservice kikisdeliveryservice changed the title fold images: remove stale refs to mc* images in install images-references fold images: remove stale refs to mc* images in install/image-references Aug 1, 2019
@kikisdeliveryservice
Copy link
Contributor Author

/test e2e-aws-op

1 similar comment
@yselkowitz
Copy link

/test e2e-aws-op

@yselkowitz
Copy link

This fixes the issues we were seeing.

@kikisdeliveryservice
Copy link
Contributor Author

PTAL: @runcom

@runcom
Copy link
Member

runcom commented Aug 2, 2019

/approve

filing a BZ as per process to get this in asap, great catch!

@runcom runcom changed the title fold images: remove stale refs to mc* images in install/image-references Bug 1737120: fold images: remove stale refs to mc* images in install/image-references Aug 2, 2019
@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1737120: fold images: remove stale refs to mc* images in install/image-references

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 2, 2019
@runcom
Copy link
Member

runcom commented Aug 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d5c5e64 into openshift:master Aug 2, 2019
@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

Details

In response to this:

Bug 1737120: fold images: remove stale refs to mc* images in install/image-references

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants