modules/dr-recover-lost-control-plane-hosts: update setup-etcd-environment

[hexfusion]

This PR updates the location of setup-etcd-environment image. This used to be its own image but is now part of the machine-config-operator [1]. I also prefixed all oc commands withsudo because core user does not have access to /var/lib/kubelet/config.json

$ ls -la /var/lib/kubelet/config.json
-rw-------. 1 root root 120 Aug 12 23:50 /var/lib/kubelet/config.json

[1] openshift/machine-config-operator#1028

[hexfusion]

/cc @alaypatel07 @retroflexer

[alaypatel07]

Is sudo required on other oc get calls? For instance, 2.i.a) oc get csr

[retroflexer]

I also prefixed all oc commands withsudo because core user does not have access to /var/lib/kubelet/config.json

$ ls -la /var/lib/kubelet/config.json
-rw-------. 1 root root 120 Aug 12 23:50 /var/lib/kubelet/config.json

Who creates this file? Why doesn't it have at least read permissions for group and others? If there is a way to avoid using sudo we should do it so.

[hexfusion]

Is sudo required on other oc get calls? For instance, 2.i.a) oc get csr

nope will update.

[hexfusion]

I also prefixed all oc commands withsudo because core user does not have access to /var/lib/kubelet/config.json

$ ls -la /var/lib/kubelet/config.json
-rw-------. 1 root root 120 Aug 12 23:50 /var/lib/kubelet/config.json

Who creates this file? Why doesn't it have at least read permissions for group and others? If there is a way to avoid using sudo we should do it so.

In general, I would agree but this is locked down for security purposes.
openshift/machine-config-operator#827

[alaypatel07]

/lgtm

[hexfusion]

/hold

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[hexfusion]

/hold cancel

[bergerhoffer]

/cherrypick enterprise-4.2

[openshift-cherrypick-robot]

@bergerhoffer: new pull request created: #16359

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.