cmd/machine-config-operator: add mco image flag to bootstrap.go #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
This is a prep step for folding all mco component images into one mco image. This flag will also be added to the installer. Related-to: openshift#739
kikisdeliveryservice
force-pushed
the
mco-image-flag
branch
from
7eba9ff to
d470a46
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kikisdeliveryservice
added a commit
to kikisdeliveryservice/installer
that referenced
this pull request
Jun 12, 2019
This is a prep step for folding all mco component images into one mco image. A corresponding mco image flag has been added in the MCO repo via openshift#847 Related-to: openshift/machine-config-operator#739 Related-to: openshift/machine-config-operator#847
kikisdeliveryservice
added a commit
to kikisdeliveryservice/machine-config-operator
that referenced
this pull request
Jun 19, 2019
This is the 3rd pr in a series to fold all MC* images into one. PR does the following as step 3: - update dockerfile.machine-config-operator to generates all component images (mco/mcc/mcd/mcs/setup-etc-env) - update dockerfile.machine-config-operator.rhel7 the same as sbove - update image-references, configmap and manifests to use MCO image - update MCO image flag in bootstrap.go to be required Related-to: openshift#847 (merged) Requires: openshift/installer#1847 (merged) Related-to: openshift#739 (issue will only close when final installer pr merges)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This is a prep step for folding all mco component images into one mco image.
This flag will also be added to the installer.
Related-to: #739
- How to verify it
This should not affect anything right now.
cc: @runcom