bootkube: add mco image #1847
bootkube: add mco image #1847
Conversation
This is a prep step for folding all mco component images into one mco image. A corresponding mco image flag has been added in the MCO repo via openshift#847 Related-to: openshift/machine-config-operator#739 Related-to: openshift/machine-config-operator#847
openshift-ci-robot
added
the
size/XS
|
/hold we need the MCO dummy flag PR first |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test e2e-aws |
|
openshift/machine-config-operator#847 has merged /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
e2e-openstack and e2e-aws-scaleup-rhel7 seem to be failing across prs? |
|
/retest |
|
/approve @wking @abhinavdahiya ptal |
|
@kikisdeliveryservice: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I looked into e2e-openstack and e2e-aws-scaleup which are failing across PRs. It's a known issue so we don't have to retest those anymore as they are not blocking/required. 😄 cc: @runcom |
|
yup, waiting on installer's team review and approval now then |
|
PTAL 🙏 so we can move forward consolidating our images /assign @wking @abhinavdahiya |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This is the 3rd pr in a series to fold all MC* images into one. PR does the following as step 3: - update dockerfile.machine-config-operator to generates all component images (mco/mcc/mcd/mcs/setup-etc-env) - update dockerfile.machine-config-operator.rhel7 the same as sbove - update image-references, configmap and manifests to use MCO image - update MCO image flag in bootstrap.go to be required Related-to: openshift#847 (merged) Requires: openshift/installer#1847 (merged) Related-to: openshift#739 (issue will only close when final installer pr merges)
6 participants
This is a prep step for folding all mco component images into one mco image.
A corresponding mco image flag has been added in the MCO repo via openshift/machine-config-operator#847
Related-to: openshift/machine-config-operator#739
Related-to: openshift/machine-config-operator#847
Required-by: openshift/machine-config-operator#850
cc: @runcom