Skip to content

OCPBUGS-1411: Bump k8s dependencies to 1.25 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Oct 18, 2022
Merged

OCPBUGS-1411: Bump k8s dependencies to 1.25 #35

openshift-merge-robot merged 3 commits into from
Oct 18, 2022

Conversation

@lobziik
Copy link
Contributor

@lobziik lobziik commented Sep 26, 2022

also update azure sdk, controller-runtime and openshift/api

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 26, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2022

@lobziik: This pull request references Jira Issue OCPBUGS-1411, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

also update azure sdk, controller-runtime and openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor

elmiko commented Sep 26, 2022

looks like something broke the unit/vet tests. possibly something missing in the vendor? (looks like compile failure)

@lobziik
Copy link
Contributor Author

lobziik commented Sep 26, 2022

Have feeling that it did use go 1.17

@lobziik
Copy link
Contributor Author

lobziik commented Sep 26, 2022

openshift/release#32619 this need to go first

@lobziik
Copy link
Contributor Author

lobziik commented Sep 27, 2022

/retest

elmiko
elmiko reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking better now
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2022

/retest-required

Remaining retests: 0 against base HEAD e62926d and 2 for PR HEAD f7aa691 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@lobziik
Copy link
Contributor Author

lobziik commented Oct 3, 2022

Added commit with golang image update from this pr #28

Fixed goimports with follow-up commit

@lobziik lobziik mentioned this pull request Oct 3, 2022
Closed
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2022

/retest-required

Remaining retests: 0 against base HEAD e62926d and 2 for PR HEAD 2c29fbc in total

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 4, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 5, 2022

/retest

1 similar comment
@lobziik
Copy link
Contributor Author

lobziik commented Oct 10, 2022

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 10, 2022
Merged
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 11, 2022

/retest-required

3 similar comments
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 12, 2022

/retest-required

@lobziik
Copy link
Contributor Author

lobziik commented Oct 12, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 13, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 14, 2022

Webhook failures are fixed by openshift/machine-api-operator#1076, otherwise tests look good. Happy for this to merge
/override ci/prow/e2e-azure-operator

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 14, 2022
Merged
@lobziik
Copy link
Contributor Author

lobziik commented Oct 17, 2022

/retest-required

1 similar comment
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 18, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 18, 2022

/override ci/prow/e2e-azure-operator

Known issue with the autoscaler tests right now which is being worked on, else this passed, happy this should merge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure-operator

Details

In response to this:

/override ci/prow/e2e-azure-operator

Known issue with the autoscaler tests right now which is being worked on, else this passed, happy this should merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@lobziik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 96739ba into openshift:main Oct 18, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2022

@lobziik: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-1411 has not been moved to the MODIFIED state.

Details

In response to this:

also update azure sdk, controller-runtime and openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lobziik @openshift-ci-robot @elmiko @JoelSpeed @openshift-merge-robot