Skip to content

OCPBUGS-1411: Bump k8s dependencies to 1.25 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 21, 2022
Merged

OCPBUGS-1411: Bump k8s dependencies to 1.25 #171

openshift-merge-robot merged 2 commits into from
Oct 21, 2022

Conversation

@lobziik
Copy link
Contributor

@lobziik lobziik commented Sep 27, 2022

Also upd controller-runtime and openshift/api

Also fake clock for testing now imports from "k8s.io/utils", since this types was removed from apimachinery, see: kubernetes/kubernetes#109752

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 27, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2022

@lobziik: This pull request references Jira Issue OCPBUGS-1411, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Also upd controller-runtime and openshift/api

Also fake clock for testing now imports from "k8s.io/utils", since this types was removed from apimachinery, see: kubernetes/kubernetes#109752

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Sep 28, 2022

/lgtm
/approve
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 28, 2022

/retest-required

Remaining retests: 0 against base HEAD 18dba4a and 2 for PR HEAD f91b00f in total

@lobziik
Copy link
Contributor Author

lobziik commented Oct 4, 2022

/test e2e-aws-capi-techpreview

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 5, 2022

/retest

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 6, 2022

/retest-required

@lobziik
Copy link
Contributor Author

lobziik commented Oct 10, 2022

/retest

@lobziik
Copy link
Contributor Author

lobziik commented Oct 10, 2022

Cherrypicked #167 and updated envtest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2022

/retest-required

Remaining retests: 0 against base HEAD 18dba4a and 2 for PR HEAD 1a9f1d4 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD 93fac26 and 1 for PR HEAD 1a9f1d4 in total

@lobziik
Copy link
Contributor Author

lobziik commented Oct 17, 2022

/retest-required

1 similar comment
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 18, 2022

/retest-required

This was referenced Oct 18, 2022
Merged
Merged
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 19, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 19, 2022

Sigh

E1019 10:05:31.497759       1 instances.go:400] Error creating EC2 instance: InsufficientInstanceCapacity: There is no Spot capacity available that matches your request.
	status code: 500, request id: d042f50d-dff1-4498-a6f9-6eca485b900c
E1019 10:05:31.497802       1 reconciler.go:93] ci-op-jzc8smhj-efb8d-mfnj4kbr2n-7d4wh: error creating machine: error creating EC2 instance: InsufficientInstanceCapacity: There is no Spot capacity available that matches your request.

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 20, 2022

/retest-required

2 similar comments
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 20, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 20, 2022

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 21, 2022

/override ci/prow/e2e-aws-operator

This got 99% of the way through and failed on the penultimate test, which is known to be broken and we are working on this. I'm happy that this change hasn't broken anything

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

Details

In response to this:

/override ci/prow/e2e-aws-operator

This got 99% of the way through and failed on the penultimate test, which is known to be broken and we are working on this. I'm happy that this change hasn't broken anything

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022 •
edited
Loading

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 1a9f1d4 link false /test e2e-aws-disruptive
ci/prow/e2e-azure-operator 1a9f1d4 link false /test e2e-azure-operator
ci/prow/e2e-gcp-operator 1a9f1d4 link false /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 21, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 3c354fd into openshift:master Oct 21, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2022

@lobziik: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-1411 has not been moved to the MODIFIED state.

Details

In response to this:

Also upd controller-runtime and openshift/api

Also fake clock for testing now imports from "k8s.io/utils", since this types was removed from apimachinery, see: kubernetes/kubernetes#109752

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lobziik @openshift-ci-robot @JoelSpeed @openshift-merge-robot