Skip to content

Conversation

@lobziik
Copy link
Contributor

@lobziik lobziik commented Sep 27, 2022

Update dependencies, bump envtest version

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 27, 2022
@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-1411, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Update dependencies, bump envtest version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 27, 2022
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0c8f48d and 2 for PR HEAD c0c034e in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@lobziik
Copy link
Contributor Author

lobziik commented Oct 3, 2022

Updated this pr:
Cherry-picked #204, updated comments formatting to align go fmt 1.19.
Also vendored setup-envtest, golangci-lint and controller-gen instead of doing go install

@lobziik
Copy link
Contributor Author

lobziik commented Oct 4, 2022

/retest

@lobziik
Copy link
Contributor Author

lobziik commented Oct 4, 2022

/test e2e-vsphere-ccm
/test e2e-vsphere-ccm-install

@lobziik
Copy link
Contributor Author

lobziik commented Oct 4, 2022

/test e2e-azure-ccm

@elmiko
Copy link
Contributor

elmiko commented Oct 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0c8f48d and 2 for PR HEAD 8729413 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ccm-install 8729413 link false /test e2e-gcp-ccm-install
ci/prow/e2e-gcp-ccm 8729413 link false /test e2e-gcp-ccm
ci/prow/e2e-azure-ccm-install 8729413 link false /test e2e-azure-ccm-install
ci/prow/e2e-vsphere-ccm-install 8729413 link false /test e2e-vsphere-ccm-install
ci/prow/e2e-azure-upgrade 8729413 link false /test e2e-azure-upgrade
ci/prow/e2e-azure-ccm 8729413 link false /test e2e-azure-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0acfa2d into openshift:master Oct 4, 2022
@openshift-ci-robot
Copy link

@lobziik: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-1411 has not been moved to the MODIFIED state.

Details

In response to this:

Update dependencies, bump envtest version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants