Update default Azure image to use image galleries #1076
Conversation
pkg/webhooks/machine_webhook.go
Outdated
| azureCachingTypeNone = "None" | ||
| azureCachingTypeReadOnly = "ReadOnly" | ||
| azureCachingTypeReadWrite = "ReadWrite" | ||
| azureRHCOSVersion = "412.86.202209220538-0" |
There was a problem hiding this comment.
Hm, I have feeling that this might change over new z-stream releases...
There was a problem hiding this comment.
Every release AFAIK, we should try to find a way to keep this up to date by looking it up witihin the cluster or somewhere but for now I want to get things fixed.
FWIW installer update their config every release
There was a problem hiding this comment.
Is there any way to reference a stable (or similar) RHCOS alias that points to the latest?
There was a problem hiding this comment.
@JoelSpeed WDYT about add a comment with some additional context?
I believe value of this constant came from this file: https://github.com/openshift/installer/blob/master/data/data/coreos/rhcos.json
Think future us might appreciate such breadcrumbs :)
There was a problem hiding this comment.
I already appreciate this breadcrumb 
|
/approve |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lobziik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
JoelSpeed
force-pushed
the
update-azure-default-image
branch
from
c2022a6 to
c816737
Compare
|
Reviewing the azure operator log, the autoscaler tests failed but the minimal webhook test is now passing again /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
damdo
left a comment
damdo
left a comment
There was a problem hiding this comment.
Nice addition the latest one.
/lgtm
|
/retest-required |
|
/override ci/prow/e2e-aws-operator All passed except the autoscaler tests, Azure proved already this change has fixed the test that was failiing |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
Since openshift/installer#6304 merged, our default webhook that defaults the Azure image resource ID has been broken. This PR updates our defaulting logic to match the format in the installer PR which should resolve the recent Azure minimal webhook test failures we've been seeing