Skip to content

Add missing ErrorCount field to BareMetalHost CRD #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andfasano wants to merge 1 commit into from
Closed

Add missing ErrorCount field to BareMetalHost CRD #747

andfasano wants to merge 1 commit into from
+6 −0

Conversation

@andfasano
Copy link

@andfasano andfasano commented Nov 11, 2020 •
edited
Loading

Updating MAO BMH crd while CBO migration is still in progress. Related to openshift/cluster-baremetal-operator#64.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 11, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign elmiko after the PR has been reviewed.
You can assign the PR to them by writing /assign @elmiko in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andfasano
Copy link
Author

andfasano commented Nov 11, 2020

cc @zaneb @sadasu

@andfasano
Copy link
Author

andfasano commented Nov 11, 2020

/retest

@andfasano
Copy link
Author

andfasano commented Nov 12, 2020

/test e2e-metal-ipi

1 similar comment
@andfasano
Copy link
Author

andfasano commented Nov 12, 2020

/test e2e-metal-ipi

zaneb
zaneb reviewed Nov 12, 2020
View reviewed changes
install/0000_30_machine-api-operator_08_baremetalhost.crd.yaml
type: string
type: object
required:
- errorCount

This comment was marked as resolved.

Sign in to view

Copy link
Author

@andfasano andfasano Nov 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I've added a default value for the field to allow smoother upgrade

(see also metal3-io/baremetal-operator#722)

@andfasano andfasano mentioned this pull request Nov 17, 2020
Merged
@zaneb
Copy link
Member

zaneb commented Nov 17, 2020

Upstream change is not accepted yet.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2020
@andfasano
Copy link
Author

andfasano commented Nov 20, 2020

Change merged upstream metal3-io/baremetal-operator#722

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@zaneb
Copy link
Member

zaneb commented Nov 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@zaneb
Copy link
Member

zaneb commented Nov 20, 2020

/retest

@zaneb
Copy link
Member

zaneb commented Nov 20, 2020

/retitle Add missing ErrorCount field to BareMetalHost CRD
/retest

@openshift-ci-robot openshift-ci-robot changed the title Add missing ErrorCount field Add missing ErrorCount field to BareMetalHost CRD Nov 20, 2020
@andfasano
Copy link
Author

andfasano commented Nov 24, 2020

/test e2e-aws

@andfasano
Copy link
Author

andfasano commented Nov 24, 2020

/test e2e-gcp

1 similar comment
@andfasano
Copy link
Author

andfasano commented Nov 24, 2020

/test e2e-gcp

@andfasano
Copy link
Author

andfasano commented Nov 25, 2020

/test ci/prow/e2e-metal-ipi

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 25, 2020

@andfasano: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-aws-operator-tech-preview
  • /test e2e-aws-upgrade
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-operator
  • /test e2e-gcp
  • /test e2e-gcp-operator
  • /test e2e-libvirt
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-vsphere-serial
  • /test generate
  • /test goimports
  • /test golint
  • /test govet
  • /test images
  • /test unit
  • /test yaml-lint

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-api-operator-master-e2e-aws
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-upgrade
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-api-operator-master-e2e-azure
  • pull-ci-openshift-machine-api-operator-master-e2e-azure-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-gcp
  • pull-ci-openshift-machine-api-operator-master-e2e-gcp-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-libvirt
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-api-operator-master-generate
  • pull-ci-openshift-machine-api-operator-master-goimports
  • pull-ci-openshift-machine-api-operator-master-golint
  • pull-ci-openshift-machine-api-operator-master-govet
  • pull-ci-openshift-machine-api-operator-master-images
  • pull-ci-openshift-machine-api-operator-master-unit
  • pull-ci-openshift-machine-api-operator-master-yaml-lint
Details

In response to this:

/test ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Author

andfasano commented Nov 25, 2020

/test e2e-metal-ipi

@andfasano
Copy link
Author

andfasano commented Dec 2, 2020

Addressed by #767

@andfasano andfasano closed this Dec 2, 2020
@andfasano andfasano deleted the update-bmh-crd branch December 2, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb zaneb left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

Assignees

@zaneb zaneb

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andfasano @openshift-ci-robot @zaneb