Skip to content

Add missing ErrorCount field to BareMetalHost CRD #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andfasano wants to merge 1 commit into from
Closed

Add missing ErrorCount field to BareMetalHost CRD #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions install/0000_30_machine-api-operator_08_baremetalhost.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ spec:
status:
description: BareMetalHostStatus defines the observed state of BareMetalHost
properties:
errorCount:
description: ErrorCount records how many times the host has encoutered
an error since the last successful operation
type: integer
default: 0
errorMessage:
description: the last error message reported by the provisioning subsystem
type: string
Expand Down Expand Up @@ -705,6 +710,7 @@ spec:
type: string
type: object
required:
- errorCount

This comment was marked as resolved.

Sign in to view

Copy link
Author

@andfasano andfasano Nov 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I've added a default value for the field to allow smoother upgrade

(see also metal3-io/baremetal-operator#722)

- errorMessage
- hardwareProfile
- operationHistory
Expand Down