Skip to content

Bug 1893832: add missing ErrorCount field#64

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:fix-1893832
Nov 4, 2020
Merged

Bug 1893832: add missing ErrorCount field#64
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:fix-1893832

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Nov 4, 2020

The BareMetalHost CRD is missing the ErrorCount field, currently required by the BareMetal Operator

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2020

@andfasano: This pull request references Bugzilla bug 1893832, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1893832: add missing ErrorCount field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
kirankt
kirankt approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@kirankt kirankt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Just adding a hold in case you want e2e-agnostic to pass, which is failing for unrelated reasons, I think. Please feel free to remove the hold if not needed.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, kirankt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@kirankt
Copy link
Contributor

kirankt commented Nov 4, 2020

/hold cancel
Just noticed that e2e-agnostic is a required job, so hold is not necessary. Sorry.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@kirankt
Copy link
Contributor

kirankt commented Nov 4, 2020

/retest

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 81f0da2 into openshift:master Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2020

@andfasano: All pull requests linked via external trackers have merged:

Bugzilla bug 1893832 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1893832: add missing ErrorCount field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano andfasano mentioned this pull request Nov 11, 2020
Closed
@hardys hardys mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadasu sadasu Awaiting requested review from sadasu

1 more reviewer

@kirankt kirankt kirankt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kirankt kirankt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andfasano @openshift-ci-robot @kirankt @openshift-bot @openshift-merge-robot