Skip to content

Add default value to BMH errorCount field #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 21, 2020
Merged

Add default value to BMH errorCount field #70

openshift-merge-robot merged 1 commit into from
Nov 21, 2020

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Nov 17, 2020

Add default value to BMH errorCount field to allow smoother upgrades.

Related to:
[1] metal3-io/baremetal-operator#722
[2] openshift/machine-api-operator#747

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@andfasano
Copy link
Contributor Author

andfasano commented Nov 17, 2020

Upstream change is not accepted yet.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2020
@andfasano
Copy link
Contributor Author

andfasano commented Nov 20, 2020

Change merged upstream metal3-io/baremetal-operator#722

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@sadasu
Copy link
Contributor

sadasu commented Nov 20, 2020

/test e2e-agnostic

@zaneb
Copy link
Member

zaneb commented Nov 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@openshift-bot
Copy link

openshift-bot commented Nov 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented Nov 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6725786 into openshift:master Nov 21, 2020
@hardys hardys mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@zaneb zaneb

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andfasano @openshift-ci-robot @sadasu @zaneb @openshift-bot @openshift-merge-robot