Skip to content

be sure to stomp admissionwebhook configuration on change#1293

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
deads2k:webhook
Jan 20, 2022
Merged

be sure to stomp admissionwebhook configuration on change#1293
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
deads2k:webhook

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 20, 2022

/assign @JoelSpeed

@JoelSpeed thanks for finding this, can you get teams to update their library-go level?

@JoelSpeed
Copy link
Contributor

Code changes seem reasonable and I think they'll fix the bug, I'll poke the people I know who use this and prompt them to update
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from soltysh January 20, 2022 14:48
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments