Bug 2041971: Revert use webhookApply implementation from Library Go

[JoelSpeed]

The library go implementation of webhook apply has been broken, it no longer updates the spec unless metadata is changed and as such, is not useful to us.

We had a working implementation before we switched to library go, so my plan is to revert the migration to library go until the implementation is fixed within library go

[openshift-ci]

@JoelSpeed: This pull request references Bugzilla bug 2041971, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 2041971: Revert use webhookApply implementation from Library Go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from joelspeed after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/test unit

[JoelSpeed]

/retest-required
/skip

[openshift-ci]

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-virtualmedia	864e9b8	link	false	/test e2e-metal-ipi-virtualmedia
ci/prow/e2e-vsphere-operator	864e9b8	link	false	/test e2e-vsphere-operator
ci/prow/e2e-metal-ipi-ovn-dualstack	864e9b8	link	false	/test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-vsphere	864e9b8	link	false	/test e2e-vsphere
ci/prow/e2e-aws-disruptive	864e9b8	link	false	/test e2e-aws-disruptive
ci/prow/e2e-vsphere-upgrade	864e9b8	link	false	/test e2e-vsphere-upgrade
ci/prow/e2e-openstack	864e9b8	link	false	/test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/hold

We may be able to fix this using openshift/library-go#1293 instead

[JoelSpeed]

/close
#981 is a better solution to this bug

[openshift-ci]

@JoelSpeed: Closed this PR.

Details

In response to this:

/close
#981 is a better solution to this bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@JoelSpeed: This pull request references Bugzilla bug 2041971. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 2041971: Revert use webhookApply implementation from Library Go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.