Bug 2045591: Fix reconciliation of aws pod identity webhook configuration

[akhil-rane]

Any changes to aws pod identity mutating webhook spec gets persisted.
Ideally, the controller should rewrite those changes with what exists in the
original manifest. With this PR, we now use mutating webhook helper
functions from library-go and openshift/library-go#1293 includes the fix for
the bug.

[akhil-rane]

/hold

fix yet to be tested

[codecov]

Codecov Report

Merging #447 (7d46e91) into master (85a406b) will increase coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   45.74%   45.92%   +0.17%     
==========================================
  Files          92       92              
  Lines        9336     9300      -36     
==========================================
  Hits         4271     4271              
+ Misses       4556     4520      -36     
  Partials      509      509              

Impacted Files	Coverage Δ
pkg/operator/awspodidentity/controller.go	0.00% <0.00%> (ø)

[joelddiaz]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [akhil-rane,joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@akhil-rane: This pull request references Bugzilla bug 2045591, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2045591: Fix reconciliation of aws pod identity webhook configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akhil-rane]

/hold cancel

tested works fine

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[akhil-rane]

/bugzilla refresh

[openshift-ci]

@akhil-rane: This pull request references Bugzilla bug 2045591, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lwan-wanglin

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@akhil-rane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@akhil-rane: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#447

Bugzilla bug 2045591 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2045591: Fix reconciliation of aws pod identity webhook configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.