Bug 2037856: Update library-go to get leader election updates by jsafrane · Pull Request #110 · openshift/cluster-csi-snapshot-controller-operator

jsafrane · 2022-01-17T13:29:53Z

Get ConfigMap + Lease leader election in 4.10 from Bug 2037856: use 'configmapsleases' based leader election library-go#1282.
And get improved WebhookConfig creation/update from be sure to stomp admissionwebhook configuration on change library-go#1293
Update snapshot-controller RBAC rules, it needs to patch snapshot objects.

@openshift/storage

openshift-ci · 2022-01-17T13:29:59Z

@jsafrane: This pull request references Bugzilla bug 2037856, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 2037856: Update library-go to get leader election updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-17T13:30:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2022-01-17T16:12:54Z

/retest

jsafrane · 2022-01-21T08:23:02Z

/retest

jsafrane · 2022-01-21T10:35:57Z

/hold
for fixes in ApplyValidatingWebhookConfiguration openshift/library-go#1293

openshift-ci · 2022-01-21T10:47:58Z

@jsafrane: This pull request references Bugzilla bug 2037856, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 2037856: Update library-go to get leader election updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2022-01-21T10:48:16Z

/hold cancel

jsafrane · 2022-01-21T12:51:28Z

/hold

event happened 34 times, something is wrong: ns/openshift-cluster-storage-operator deployment/csi-snapshot-controller-operator - reason/ValidatingWebhookConfigurationUpdated Updated ValidatingWebhookConfiguration.admissionregistration.k8s.io/snapshot.storage.k8s.io because it changed

ingvagabund · 2022-01-24T23:24:48Z

/retest-required

Namely openshift/library-go#1282

ApplyValidatingWebhookConfigurationImproved makes sure that the instance is updated when the asset in the operator is updated.

jsafrane · 2022-01-25T10:01:23Z

Updated library-go again to get openshift/library-go#1294

jsafrane · 2022-01-25T10:01:42Z

/hold cancel

The operand now requires permissions to patch VolumeSnapshot + VolumeSnapshotContent (+ their statuses). See kubernetes-csi/external-snapshotter#526

openshift-ci · 2022-01-25T11:55:55Z

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-25T12:06:10Z

@jsafrane: This pull request references Bugzilla bug 2037856, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 2037856: Update library-go to get leader election updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-25T12:06:18Z

@jsafrane: This pull request references Bugzilla bug 2037856, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 2037856: Update library-go to get leader election updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bertinatto

/lgtm

openshift-ci · 2022-01-25T12:33:52Z

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 2037856 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2037856: Update library-go to get leader election updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 17, 2022

openshift-ci bot requested review from bertinatto, dobsonj and wangke19 January 17, 2022 13:30

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022

This was referenced Jan 17, 2022

Bug 2037856: bump library go openshift/cluster-kube-descheduler-operator#236

Merged

Bug 2037856: bump library go openshift/cluster-kube-apiserver-operator#1294

Merged

ingvagabund mentioned this pull request Jan 19, 2022

bug 2039670: Skip deployment of PDBs on the SNO topology #109

Merged

This was referenced Jan 20, 2022

Bug 2037856: Update library-go to get leader election updates openshift/vsphere-problem-detector#71

Merged

Bug 2037856: Update library-go to get leader election updates openshift/cluster-storage-operator#255

Merged

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022

jsafrane force-pushed the lease-leaderelection branch 2 times, most recently from d6c338d to e88f96d Compare January 21, 2022 10:47

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022

openshift-ci bot mentioned this pull request Jan 24, 2022

Bug 2037856: bump library go openshift/cluster-kube-controller-manager-operator#590

Merged

jsafrane added 2 commits January 25, 2022 10:58

Update library-go to get leader election updates

97e0e2e

Namely openshift/library-go#1282

Update webhook sync

27bed8b

ApplyValidatingWebhookConfigurationImproved makes sure that the instance is updated when the asset in the operator is updated.

jsafrane force-pushed the lease-leaderelection branch from e88f96d to 27bed8b Compare January 25, 2022 10:01

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2022

Add new snapshot-controller RBAC rules

517f6d8

The operand now requires permissions to patch VolumeSnapshot + VolumeSnapshotContent (+ their statuses). See kubernetes-csi/external-snapshotter#526

bertinatto reviewed Jan 25, 2022

View reviewed changes

openshift-ci bot assigned bertinatto Jan 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022

openshift-merge-robot merged commit 7272d49 into openshift:master Jan 25, 2022

openshift-ci bot mentioned this pull request Jan 25, 2022

Bug 2037856: Fix typo in VolumeSnapshotContents RBAC #112

Merged

Conversation

jsafrane commented Jan 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 17, 2022

Uh oh!

openshift-ci bot commented Jan 17, 2022

Uh oh!

jsafrane commented Jan 17, 2022

Uh oh!

jsafrane commented Jan 21, 2022

Uh oh!

jsafrane commented Jan 21, 2022

Uh oh!

openshift-ci bot commented Jan 21, 2022

Uh oh!

jsafrane commented Jan 21, 2022

Uh oh!

jsafrane commented Jan 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ingvagabund commented Jan 24, 2022

Uh oh!

jsafrane commented Jan 25, 2022

Uh oh!

jsafrane commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

jsafrane commented Jan 17, 2022 •

edited

Loading

jsafrane commented Jan 21, 2022 •

edited

Loading