Bug 2034484: fix: missed rbac and latest library-go by eggfoobar · Pull Request #236 · openshift/cluster-autoscaler-operator

eggfoobar · 2021-12-21T06:17:36Z

updated to include missed rbac permission for infrastructure resource
updated library-go to latest for fix in pr openshift/library-go#1273

Signed-off-by: ehila ehila@redhat.com

updated to include missed rbac permission for infrastructure resource updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>

eggfoobar · 2021-12-21T14:38:46Z

/retitle Bug 2034484: fix: missed rbac and latest library-go
this PR pulls in the latest library-go to utilize needed performance improvements, and fixes rbac bug

openshift-ci · 2021-12-21T14:38:51Z

@eggfoobar: This pull request references Bugzilla bug 2034484, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2034484: fix: missed rbac and latest library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eggfoobar · 2021-12-21T14:42:54Z

/bugzilla refresh

openshift-ci · 2021-12-21T14:42:57Z

@eggfoobar: This pull request references Bugzilla bug 2034484, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eggfoobar · 2021-12-21T14:43:39Z

/retest-required

elmiko · 2021-12-21T15:04:31Z

/bugzilla refresh

openshift-ci · 2021-12-21T15:04:38Z

@elmiko: This pull request references Bugzilla bug 2034484, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko

this generally looks good to me, just having a little trouble linking the permission to code.

elmiko · 2021-12-21T15:06:34Z

+- apiGroups:
+    - config.openshift.io
+  resources:
+    - infrastructures


i looked through the code but i couldn't see where this operator is attempting to use an infrastructure object, do we need this permission?

Ah sorry, that was in the previous PR, it's being called here https://github.com/openshift/cluster-autoscaler-operator/pull/235/files#diff-c2a06a8d073270721be5c29036cf48fc7b1cffe05223c2f277fbe46bc967180aR46

ahh, thank you very much. i missed that call.

elmiko · 2021-12-21T16:12:34Z

/approve

openshift-ci · 2021-12-21T16:14:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qJkee · 2021-12-21T19:48:14Z

/retest-required

qJkee · 2021-12-21T20:04:25Z

/retest-required

openshift-ci · 2021-12-21T22:01:13Z

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fedosin

/lgtm

openshift-ci · 2021-12-22T19:12:12Z

@eggfoobar: Some pull requests linked via external trackers have merged:

openshift/cluster-autoscaler-operator#236

The following pull requests linked via external trackers have not merged:

openshift/cluster-config-operator#227 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2034484 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2034484: fix: missed rbac and latest library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fix: missed rbac and latest library-go

4944eca

updated to include missed rbac permission for infrastructure resource updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>

openshift-ci Bot requested review from elmiko and lobziik December 21, 2021 06:18

openshift-ci Bot changed the title ~~fix: missed rbac and latest library-go~~ Bug 2034484: fix: missed rbac and latest library-go Dec 21, 2021

openshift-ci Bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 21, 2021

openshift-ci Bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 21, 2021

openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 21, 2021

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 21, 2021

elmiko reviewed Dec 21, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021

openshift-ci Bot mentioned this pull request Dec 21, 2021

Bug 2034484: feat: bumped library-go openshift/local-storage-operator#304

Merged

Fedosin approved these changes Dec 22, 2021

View reviewed changes

openshift-ci Bot assigned Fedosin Dec 22, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021

openshift-merge-robot merged commit a09e626 into openshift:master Dec 22, 2021

openshift-ci Bot mentioned this pull request Jan 7, 2022

Bug 2034484: fix:library-go nil pointer issue openshift/cluster-authentication-operator#525

Merged

Conversation

eggfoobar commented Dec 21, 2021

Uh oh!

eggfoobar commented Dec 21, 2021

Uh oh!

openshift-ci Bot commented Dec 21, 2021

Uh oh!

eggfoobar commented Dec 21, 2021

Uh oh!

openshift-ci Bot commented Dec 21, 2021

Uh oh!

eggfoobar commented Dec 21, 2021

Uh oh!

elmiko commented Dec 21, 2021

Uh oh!

openshift-ci Bot commented Dec 21, 2021

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

elmiko Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

eggfoobar Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

elmiko Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

elmiko commented Dec 21, 2021

Uh oh!

openshift-ci Bot commented Dec 21, 2021

Uh oh!

qJkee commented Dec 21, 2021

Uh oh!

qJkee commented Dec 21, 2021

Uh oh!

openshift-ci Bot commented Dec 21, 2021

Uh oh!

Fedosin left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Dec 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants