Rebase 1.21.0 rc.0 #641
Rebase 1.21.0 rc.0 #641
Conversation
…be-test-with-kubelet-version e2e/common/node: tag tests with MinimumKubeletVersion
Upgrade klog to avoid panics crashing components
Signed-off-by: JunYang <[email protected]>
Remove double-ownership of PV ResourceQuota tests
Update list of migrated directories
initialise capabilities unit test
Split upgrade tests into sig-owned directories
…o, cpu_assignment.go} to structured logging
…cleanup remove e2e volume registry as it is not used
kubeadm unit test initalize global variables
test: remove gcr.io/gke-release since it is deprecated
Include nltest in the windows busybox image
…ainer` This enables building the conformance image when running `make cross-in-a-container`, which is being used by the release engineering tooling. Signed-off-by: Sascha Grunert <[email protected]>
Only default Job fields when feature gates are enabled
passing all packages at once to logcheck reduces the time taken by linter. Signed-off-by: Umanga Chapagain <[email protected]>
- Adjust the period to trigger PodUpdate event - Fix lock race between 'changeFile' and 'expectUpdate' - Await fsnotify to be ready
disable flaky TestClientReceivedGOAWAY test case
soltysh
force-pushed
the
rebase-1.21.0-rc.0
branch
from
d3d95b4 to
d101b9e
Compare
openshift-ci-robot
added
the
backports/unvalidated-commits
|
Tests were green, but we needed a rebase onto master due to merge conflicts. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/verify-commits |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| "[Top Level] [sig-network] Conntrack should be able to preserve UDP traffic when server pod cycles for a NodePort service": "should be able to preserve UDP traffic when server pod cycles for a NodePort service [Suite:openshift/conformance/parallel] [Suite:k8s]", | ||
|
|
||
| "[Top Level] [sig-network] Conntrack should drop INVALID conntrack entries": "should drop INVALID conntrack entries [Suite:openshift/conformance/parallel] [Suite:k8s]", | ||
| "[Top Level] [sig-network] Conntrack should drop INVALID conntrack entries": "should drop INVALID conntrack entries [Disabled:Broken] [Suite:k8s]", |
There was a problem hiding this comment.
Opened https://bugzilla.redhat.com/show_bug.cgi?id=1945329 for networking team to investigate.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test k8s-e2e-gcp |
|
/retest |
soltysh
removed
the
backports/unvalidated-commits
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Upstream docs [1]: kubelet must not be newer than kube-apiserver, and may be up to two minor versions older. The coming OpenShift 4.8 is aiming at 1.21 [2]. This commit will end up in 4.8. So when it is considering Upgradeable guards, it is saying "is the current state compatible with the next OpenShift minor?". The next minor will be 4.9, which will presumably run 1.22. So it will be compatible with 1.20, 1.21, and 1.22 kubelets. If for some reason OpenShift 4.9 ends up being compatible with 1.19 too (say, because it sticks with 4.8's 1.21), we'll backport a patch to the 4.8 cluster-version operator to bring that wisdom back. Those next-minor-knowledge backports are the best we can do unless we get something like preflight checks [3]. I'm not wildly excited about the current framework. It has lots of informers, and I think we might want a single NewSharedInformer to reduce the number of parallel watches. It also periodically polls all of the upgradeable checks, and I would prefer a framework where our informers fed queues and we had workers processing change events from those queues to trigger state changes, which should give us lower latency reactions. But since we may end up taking this code back to 4.6, the current commit is a minimal addition following the existing patterns, and we can consider more extensive refactors once we have the backport-friendly pivot in place. [1]: https://kubernetes.io/docs/setup/release/version-skew-policy/#kubelet [2]: openshift/kubernetes#641 [3]: openshift/enhancements#363
|
/refresh |
|
/override ci/prow/verify-commits |
|
/refresh |
|
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
20 participants
Tracking sheet https://docs.google.com/spreadsheets/d/10KYptJkDB1z8_RYCQVBYDjdTlRfyoXILMa0Fg8tnNlY/edit#gid=1904553197