Skip to content

Conversation

@erictune
Copy link
Contributor

@erictune erictune commented Oct 1, 2014

No description provided.

@erictune
Copy link
Contributor Author

erictune commented Oct 1, 2014

Fixes #992

@thockin
Copy link
Member

thockin commented Oct 1, 2014

I am fine with this, even happy with it, but I thought the preponderance of opinions was that Dir was less good than Directory?

@thockin
Copy link
Member

thockin commented Oct 1, 2014

As a followup we should rename HostDir to HostPath in v1beta3

@erictune
Copy link
Contributor Author

erictune commented Oct 1, 2014

I thought that we don't want the name to be different than in json, and that there is already config that depends on the name emptyDir and/or hostDir.

@thockin
Copy link
Member

thockin commented Oct 2, 2014

That logic works for me, but I'll leave this open for dissent for a day or
two.

On Wed, Oct 1, 2014 at 4:40 PM, erictune [email protected] wrote:

I thought that we don't want the name to be different than in json, and
that there is already config that depends on the name emptyDir and/or
hostDir.

Reply to this email directly or view it on GitHub
#1525 (comment)
.

@dchen1107
Copy link
Member

I am ok with renaming Directory to Dir once they are consistent.
LGTM

@bgrant0607
Copy link
Member

Discussion on the v1beta3 issue: #1225 (comment)

@erictune
Copy link
Contributor Author

erictune commented Oct 2, 2014

Suggest we merge this now and discuss naming changes when v1beta4 opens for changes.

thockin added a commit that referenced this pull request Oct 2, 2014
Directory renamed to Dir to match json property
@thockin thockin merged commit 1dda307 into kubernetes:master Oct 2, 2014
@erictune erictune deleted the rename_dir branch October 8, 2014 22:08
k8s-ci-robot added a commit that referenced this pull request Mar 15, 2021
test: remove gcr.io/gke-release since it is deprecated
k8s-ci-robot added a commit that referenced this pull request Jul 15, 2021
device-plugins: replace gcr.io/gke-release to use the community registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants