UPSTREAM: <carry>: Add Dockerfile to build pause image #633
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@umohnani8: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
We want to build the Currently the Dockerfile for the pod image being shipped is at https://github.com/openshift/images/blob/master/pod/Dockerfile and the reference to build that Dockerfile for the pod image is at https://github.com/openshift/ocp-build-data/blob/openshift-4.8/images/openshift-enterprise-pod.yml. Should the new Dockerfile live here? Or should we copy the contents of This also doesn't currently handle multiple architectures and I am not seeing how we do it for the current pod image that we ship. Would appreciate any pointers to how we can handle this for the various architectures we support. |
|
It's ok to publish this here, then we need to update ART to pull from this repo instead of openshift/images and at the same time stop openshift/images from publishing this. It's ok to have both publishing briefly (days) since the images are expected to be compatible. |
|
/retest |
|
@umohnani8: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
umohnani8
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@smarterclayton how do we handle multi-arch for the pod image we currently ship? Do I need to do anything in this Dockerfile to account for that? |
|
/retest |
|
@smarterclayton @sjenning @mrunalp PTAL. This should be ready if nothing more is needed for multi-arch. |
|
/approve Once the symlink is in |
Build the pause binary provided by the upstream k8s/k8s repo and use that as the infra image in OpenShift. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
@umohnani8: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/retest |
|
/assign @soltysh |
|
/retest |
openshift-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
20 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
mrunalp
added
the
bugzilla/valid-bug
Since openshift/kubernetes#633 and openshift-eng#873, builds for `openshift-enterprise-pod` started to fail because `glibc-static` could not get installed. This commit adds the rhel-8 repository for the glibc-static rpm.
Since openshift/kubernetes#633 and openshift-eng#873, builds for `openshift-enterprise-pod` started to fail because `glibc-static` could not get installed. This commit adds the rhel-8 repository for the glibc-static rpm.
8 participants
Signed-off-by: Urvashi Mohnani umohnani@redhat.com
What type of PR is this?
What this PR does / why we need it:
Build the pause binary provided by the upstream
k8s/k8s repo and use that as the infra image in
OpenShift.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: