Upgrade klog to avoid panics crashing components #100156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
pacoxu
approved these changes
Mar 12, 2021
Member
|
please use klog |
ehashman
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/sig node FYI |
k8s-ci-robot
added
the
sig/node
Member
|
/milestone v1.21 (since this is a critical fix) |
Member
|
Need ./hack/update-internal-modules.sh ？ |
Member
Author
|
flake #99801 |
Member
Author
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Member
Author
Member
|
/approve |
k8s-ci-robot
added
the
lgtm
Member
|
/assign @liggitt |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, ehashman, liggitt, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
Looks like: /test pull-kubernetes-e2e-kind |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind flake
/priority critical-urgent
What this PR does / why we need it:
Upgrades klog to pull in critical bugfixes.
Which issue(s) this PR fixes:
Fixes #100155 and #98976 (comment). These are the only two changes in the vendor diff.
Special notes for your reviewer:
Waiting on a klog release, testing this against HEAD for now.Upgraded to klog v2.8.0.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @dims @serathius @pacoxu