openshift-4.8: Update Dockerfile for pod yaml#873
Merged
sosiouxme merged 1 commit intoopenshift-eng:openshift-4.8from Apr 16, 2021
Merged
openshift-4.8: Update Dockerfile for pod yaml#873sosiouxme merged 1 commit intoopenshift-eng:openshift-4.8from
sosiouxme merged 1 commit intoopenshift-eng:openshift-4.8from
Conversation
|
@umohnani8: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Author
|
Wait for openshift/kubernetes#633 to get in first. |
Build #1 |
|
@umohnani8: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
umohnani8
changed the title
|
Now that ubi8/pause exists, maybe we could just migrate openshift to use that instead? |
Author
|
@yselkowitz the ubi8/pause image is around 250MB as well, our goal here is to bring the size of the pause image down as much as possible. And doing a build from scratch creates a pod image that is about 1MB in size. |
|
standalone image size is not a factor because images work in layers. all of ocp is already based on ubi8, so using ubi8/pause comes with almost zero additional cost. in fact, this patch doesn't change the base of pod either. |
Author
|
How is the base of the pod image staying the same with this patch? From what I understand, you point to the Dockerfile you want built in the yaml and it builds that to create the image. The new Dockerfile is https://github.com/openshift/kubernetes/pull/633/files, which uses scratch as the base. |
|
The image yamls specify images or streams which are to be the downstream base(s) of the image, which are then substituted in the |
|
Yeah, agree that having a base layer doesn't matter. We are more looking at per instance memory overhead at runtime vs go. If possible, we could make this dynamically linked instead. |
Author
|
@yselkowitz got it, thanks for the info! How would we go about using the ubi8/pause image here instead? |
Author
|
Actually, looking at the how the ubi8/pause image is built, https://catalog.redhat.com/software/containers/rhel8/pause/5f7812eb0eae6156657d4607?tag=8.3-11&container-tabs=dockerfile, it is just an infinite sleep which does not work for Openshift. We need pid reaping, which is provided by the pause.c binary from https://github.com/openshift/kubernetes/blob/master/build/pause/linux/pause.c. And we want to move to use pause.c instead of the Go binary we are currently using to help improve memory overhead at runtime. |
Contributor
|
LGTM but sounds like we are waiting on openshift/kubernetes#633 |
openshift-ci-robot
added
the
do-not-merge/hold
Author
|
@sosiouxme openshift/kubernetes#633 got merged, this is ready now. |
yselkowitz
suggested changes
Apr 13, 2021
Build #2 |
yselkowitz
suggested changes
Apr 13, 2021
Build #3 |
Build #4 |
yselkowitz
suggested changes
Apr 13, 2021
Update the openshift-enterprise-pod.yaml to point to the Dockerfile under openshift/k8s/build/pause so we build a pod image containing the pause.c binary bringing down the pod image size from ~250MB to ~1MB. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
This should be ready for ART review now. |
openshift-ci-robot
removed
the
do-not-merge/hold
Build #5 |
Author
|
@sosiouxme PTAL, this is ready :) |
sosiouxme
reviewed
Apr 15, 2021
joepvd
added a commit
to joepvd/ocp-build-data
that referenced
this pull request
Apr 20, 2021
Since openshift/kubernetes#633 and openshift-eng#873, builds for `openshift-enterprise-pod` started to fail because `glibc-static` could not get installed. This commit adds the rhel-8 repository for the glibc-static rpm.
sosiouxme
pushed a commit
to sosiouxme/ocp-build-data
that referenced
this pull request
May 5, 2021
Since openshift/kubernetes#633 and openshift-eng#873, builds for `openshift-enterprise-pod` started to fail because `glibc-static` could not get installed. This commit adds the rhel-8 repository for the glibc-static rpm.
stbenjam
added a commit
to stbenjam/release
that referenced
this pull request
May 6, 2021
Since openshift-eng/ocp-build-data#873, the pause image is built from openshift/kubernetes instead of openshift/images.
umohnani8
added a commit
to umohnani8/release
that referenced
this pull request
May 7, 2021
Since openshift-eng/ocp-build-data#873, the pause image is built from openshift/kubernetes instead of openshift/images. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the openshift-enterprise-pod.yaml to
point to the Dockerfile under openshift/k8s/build/pause
so we build a pod image containing the pause.c binary
bringing down the pod image size from ~250MB to ~1MB.
Signed-off-by: Urvashi Mohnani umohnani@redhat.com