Bug 1951585: Addresses build error pause #685

joepvd · 2021-04-20T09:20:26Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Follow-up of #633. Related: openshift-eng/ocp-build-data#898.

Ensuring the target directory exists before writing a file to it, and fixes build failure:

 /usr/bin/ld: cannot open output file bin/pause: No such file or directory

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

openshift-ci-robot · 2021-04-20T09:21:31Z

@joepvd: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

9d2b1be|build/pause: Fix build error: does not specify an upstream backport in the commit message

joepvd · 2021-04-20T13:54:02Z

/retest

openshift-ci-robot · 2021-04-20T13:58:09Z

@joepvd: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

4225615|UPSTREAM: : Fix build error build/pause: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-04-20T14:04:53Z

@joepvd: This pull request references Bugzilla bug 1951585, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1951585: Addresses build error pause

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joepvd · 2021-04-20T14:06:00Z

/bugzilla refresh

openshift-ci-robot · 2021-04-20T14:06:11Z

@joepvd: This pull request references Bugzilla bug 1951585, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

Rename the commit to:
UPSTREAM: <carry>: Add Dockerfile to build pause image
so that during next k8s bump we squash this commit with the other one.

Ensuring the target directory exists before writing a file to it.

openshift-ci-robot · 2021-04-20T15:03:43Z

@joepvd: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

8a23b51|UPSTREAM: : Add Dockerfile to build pause image: does not specify an upstream backport in the commit message

joepvd · 2021-04-20T15:47:54Z

/bugzilla refresh

openshift-ci-robot · 2021-04-20T15:47:59Z

@joepvd: This pull request references Bugzilla bug 1951585, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joepvd · 2021-04-20T19:29:16Z

/retest

joepvd · 2021-04-21T04:44:39Z

/retest

joepvd · 2021-04-21T07:15:41Z

/retest

joepvd · 2021-04-21T10:45:56Z

/retest

joepvd · 2021-04-21T13:44:26Z

/test e2e-gcp-upgrade

openshift-bot · 2021-04-26T20:56:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T07:42:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

joepvd · 2021-04-27T11:48:52Z

/assign @sttts

joepvd · 2021-04-27T15:43:24Z

/retest

openshift-bot · 2021-04-27T15:53:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T20:43:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

yselkowitz · 2021-04-27T23:33:20Z

ose-pod has not built successfully in 4.8 for two weeks now, please expedite.

openshift-bot · 2021-04-27T23:41:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T23:54:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T06:36:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T07:20:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

soltysh · 2021-04-28T11:06:08Z

This is unblocking builds and doesn't change functionality

/override ci/prow/e2e-aws-fips
/override ci/prow/k8s-e2e-gcp
/override ci/prow/e2e-gcp-upgrade

openshift-ci-robot · 2021-04-28T11:06:45Z

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-fips, ci/prow/e2e-gcp-upgrade, ci/prow/k8s-e2e-gcp

Details

In response to this:

This is unblocking nightly builds and doesn't change functionality

/override ci/prow/e2e-aws-fips
/override ci/prow/k8s-e2e-gcp
/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-28T13:47:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T16:35:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T16:48:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T18:35:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T19:47:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

yselkowitz · 2021-04-28T22:58:00Z

/retest

openshift-bot · 2021-04-29T01:24:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-29T02:00:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

joepvd · 2021-04-29T08:21:13Z

/retest

joepvd · 2021-04-29T10:01:54Z

/retest

openshift-bot · 2021-04-29T10:17:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

joepvd · 2021-04-29T12:54:27Z

/retest

joepvd · 2021-04-29T14:54:02Z

Could the failing tests be overridden? Think it'd be good to have an updated image in the upcoming fc.

openshift-bot · 2021-04-29T15:13:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-29T15:26:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-30T00:05:28Z

@joepvd: All pull requests linked via external trackers have merged:

openshift/kubernetes#685

Bugzilla bug 1951585 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1951585: Addresses build error pause

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Apr 20, 2021

openshift-ci-robot requested review from soltysh and sttts April 20, 2021 09:21

joepvd mentioned this pull request Apr 20, 2021

[4.8] Fix enterprise-pod build openshift-eng/ocp-build-data#898

Merged

joepvd force-pushed the pause-fix-build branch from 9d2b1be to 4225615 Compare April 20, 2021 13:58

joepvd changed the title ~~Addresses build error pause~~ Bug 1951585: Addresses build error pause Apr 20, 2021

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 20, 2021

soltysh suggested changes Apr 20, 2021

View reviewed changes

UPSTREAM: <carry>: Add Dockerfile to build pause image

8a23b51

Ensuring the target directory exists before writing a file to it.

joepvd force-pushed the pause-fix-build branch from 4225615 to 8a23b51 Compare April 20, 2021 15:03

openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Apr 20, 2021

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 20, 2021

openshift-merge-robot merged commit 5afcd97 into openshift:master Apr 30, 2021

Bug 1951585: Addresses build error pause #685

Bug 1951585: Addresses build error pause #685

Uh oh!

Conversation

joepvd commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

joepvd commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

joepvd commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

joepvd commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

joepvd commented Apr 20, 2021

Uh oh!

joepvd commented Apr 21, 2021

Uh oh!

joepvd commented Apr 21, 2021

Uh oh!

joepvd commented Apr 21, 2021

Uh oh!

joepvd commented Apr 21, 2021

Uh oh!

openshift-bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

joepvd commented Apr 27, 2021

Uh oh!

joepvd commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

yselkowitz commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

soltysh commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

joepvd commented Apr 20, 2021 •

edited

Loading

soltysh commented Apr 28, 2021 •

edited

Loading