Skip to content

OCPBUGS-30642: Revert "Generate PowerVS machine manifests for CAPI" and subsequent vendoring changes #8135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stbenjam wants to merge 3 commits into from
Closed

OCPBUGS-30642: Revert "Generate PowerVS machine manifests for CAPI" and subsequent vendoring changes #8135

stbenjam wants to merge 3 commits into from

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 11, 2024 •
edited by openshift-ci bot
Loading

Reverts #7546, #8020, #8114; tracked by TRT-1556

Reverting the original change, and subsequent vendoring changes that are required for a clean revert.

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

GCP installs are failing on 4.16.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

GCP installs succeed

CC: @qJkee, @hamzy, @r4f4

stbenjam added 3 commits March 11, 2024 06:38
@stbenjam
Revert "Merge pull request openshift#7546 from qJkee/OCPVE-661"
5652ede 
This reverts commit e245acb, reversing
changes made to 1b99648.
@stbenjam
Revert "Merge pull request openshift#8114 from r4f4/capa-bump-lb-fix"
055cc9c 
This reverts commit 5f86562, reversing
changes made to 0174482.
@stbenjam
Revert "Merge pull request openshift#8020 from hamzy/PowerVS-MULTIARC…
4290d84 
…H-4095"

This reverts commit 1b99648, reversing
changes made to cc61152.
@stbenjam
Copy link
Member Author

stbenjam commented Mar 11, 2024

Alternative to #8133

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@stbenjam
Copy link
Member Author

stbenjam commented Mar 11, 2024

/test e2e-gcp-ovn

@openshift-ci openshift-ci bot requested review from andfasano and bfournie March 11, 2024 10:49
@r4f4
Copy link
Contributor

r4f4 commented Mar 11, 2024

/retitle OCPBUGS-30642: Revert "Generate PowerVS machine manifests for CAPI" and subsequent vendoring changes

@openshift-ci openshift-ci bot changed the title Revert "Generate PowerVS machine manifests for CAPI" and subsequent vendoring changes OCPBUGS-30642: Revert "Generate PowerVS machine manifests for CAPI" and subsequent vendoring changes Mar 11, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 11, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2024

@stbenjam: This pull request references Jira Issue OCPBUGS-30642, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #7546, #8020, #8114; tracked by TRT-1556

Reverting the original change, and subsequent vendoring changes that are required for a clean revert.

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

GCP installs are failing on 4.16.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

GCP installs succeed

CC: @qJkee, @hamzy, @r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jianli-wei March 11, 2024 11:59
@r4f4
Copy link
Contributor

r4f4 commented Mar 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 11, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-wavelengthzones 4290d84 link false /test altinfra-e2e-aws-ovn-wavelengthzones
ci/prow/e2e-openstack-nfv-intel 4290d84 link false /test e2e-openstack-nfv-intel
ci/prow/okd-e2e-aws-ovn-upgrade 4290d84 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-edge-zones 4290d84 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-ibmcloud-ovn 4290d84 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-openstack-proxy 4290d84 link false /test e2e-openstack-proxy
ci/prow/e2e-gcp-ovn-xpn 4290d84 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-aws-ovn-single-node 4290d84 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Mar 11, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 11, 2024
Merged
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 14, 2024

/close
in favor of #8133

@openshift-ci openshift-ci bot closed this Mar 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@patrickdillon: Closed this PR.

Details

In response to this:

/close
in favor of #8133

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

Assignees

@r4f4 r4f4

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stbenjam @r4f4 @openshift-ci-robot @patrickdillon @openshift-merge-robot