CORS-3288: bump CAPA for LB scheme fix #8114
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@r4f4: This pull request references CORS-3288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This makes it possible to have public subnets associated with an external secondary LB.
|
Update: somehow I missed a "go mod tidy". Fixed. |
|
/approve Does it require updates to infrastructure-components.yaml? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Good point. I see some upstream changes to support ignition proxy, so I'll update it. |
So CRD matches the CAPA version used.
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
barbacbd
left a comment
barbacbd
left a comment
There was a problem hiding this comment.
/lgtm
Since this is not an official release of CAPA the CRD and infrastructures will not match the upstream (they were generated here), and this is ok.
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403081913.p0.g5f86562.assembly.stream.el8 for distgit ose-installer-altinfra. |
Fallout from openshift#8114. I missed the replacing pinning the CAPA version to 2.4.0. We need the newer version to be able to specify ignition proxy information.
Fallout from openshift#8114. I missed the replacing pinning the CAPA version to 2.4.0. We need the newer version to be able to specify ignition proxy information.
5 participants
This makes it possible to have public subnets associated with an external secondary LB.