Skip to content

MULTIARCH-4095: Generate PowerVS machine manifests for CAPI #8020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Mar 7, 2024
Merged

MULTIARCH-4095: Generate PowerVS machine manifests for CAPI #8020

openshift-merge-bot merged 3 commits into from
Mar 7, 2024

Conversation

@hamzy
Copy link
Contributor

@hamzy hamzy commented Feb 14, 2024

Generate the PowerVS master and bootstrap machine manifests for CAPI.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2024 •
edited by openshift-ci bot
Loading

@hamzy: This pull request references MULTIARCH-4095 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Generate the PowerVS master and bootstrap machine manifests for CAPI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2024
@hamzy hamzy force-pushed the PowerVS-MULTIARCH-4095 branch from 02cb16a to ae8c04a Compare February 29, 2024 16:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@hamzy hamzy force-pushed the PowerVS-MULTIARCH-4095 branch 3 times, most recently from 2b557df to 36f9701 Compare March 1, 2024 23:59
@hamzy
Copy link
Contributor Author

hamzy commented Mar 2, 2024

/retest-required

@hamzy hamzy force-pushed the PowerVS-MULTIARCH-4095 branch from 36f9701 to 72067c8 Compare March 5, 2024 12:58
@hamzy hamzy changed the title WIP: MULTIARCH-4095: Generate PowerVS machine manifests for CAPI MULTIARCH-4095: Generate PowerVS machine manifests for CAPI Mar 5, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Mar 5, 2024

/assign @patrickdillon
I don't know if this is the final version yet, but I would like to commit these changes in order to avoid having to repeatedly fix merge conflicts in the vendoring.

@mjturek
Copy link
Contributor

mjturek commented Mar 6, 2024

/lgtm as mark said they may not be 100% correct but won't break anything

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
patrickdillon
patrickdillon approved these changes Mar 6, 2024
View reviewed changes
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 6, 2024

Absolutely, totally fine to merge and iterate

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@hamzy hamzy force-pushed the PowerVS-MULTIARCH-4095 branch from 72067c8 to 93edc20 Compare March 6, 2024 15:48
@mjturek
Copy link
Contributor

mjturek commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@hamzy hamzy force-pushed the PowerVS-MULTIARCH-4095 branch from 93edc20 to cfbd115 Compare March 6, 2024 16:04
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@mjturek
Copy link
Contributor

mjturek commented Mar 6, 2024

/lgtm

1 similar comment
@mjturek
Copy link
Contributor

mjturek commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024

/retest-required

Remaining retests: 0 against base HEAD a6cd30f and 2 for PR HEAD cfbd115 in total

@hamzy
Copy link
Contributor Author

hamzy commented Mar 6, 2024

/test e2e-gcp-ovn

2 similar comments
@mjturek
Copy link
Contributor

mjturek commented Mar 6, 2024

/test e2e-gcp-ovn

@hamzy
Copy link
Contributor Author

hamzy commented Mar 6, 2024

/test e2e-gcp-ovn

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 6, 2024

/override ci/prow/e2e-gcp-ovn

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 6, 2024

/skip

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 6, 2024

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-wavelengthzones cfbd115 link false /test altinfra-e2e-aws-ovn-wavelengthzones
ci/prow/e2e-gcp-secureboot cfbd115 link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn-fips cfbd115 link false /test e2e-aws-ovn-fips
ci/prow/e2e-ibmcloud-ovn cfbd115 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-gcp-ovn-shared-vpc cfbd115 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/okd-e2e-aws-ovn-upgrade cfbd115 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/altinfra-e2e-aws-ovn-single-node cfbd115 link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-xpn cfbd115 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-aws-ovn-single-node cfbd115 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1b99648 into openshift:master Mar 7, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 7, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403071047.p0.g1b99648.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

r4f4 added a commit to r4f4/installer that referenced this pull request Mar 8, 2024
@r4f4
Revert "Merge pull request openshift#8020 from hamzy/PowerVS-MULTIARC…
aece693 
…H-4095"

This reverts commit 1b99648, reversing
changes made to cc61152.
@r4f4 r4f4 mentioned this pull request Mar 8, 2024
Closed
stbenjam added a commit to stbenjam/installer that referenced this pull request Mar 11, 2024
@stbenjam
Revert "Merge pull request openshift#8020 from hamzy/PowerVS-MULTIARC…
4290d84 
…H-4095"

This reverts commit 1b99648, reversing
changes made to cc61152.
@stbenjam stbenjam mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon approved these changes

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

Assignees

@patrickdillon patrickdillon

@mjturek mjturek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hamzy @openshift-ci-robot @mjturek @patrickdillon @openshift-bot @openshift-merge-robot