Skip to content

OCPVE-661, OCPBUGS-24415: bump openshift/api version #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Mar 7, 2024
Merged

OCPVE-661, OCPBUGS-24415: bump openshift/api version #7546

openshift-merge-bot merged 2 commits into from
Mar 7, 2024

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented Oct 2, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2023 •
edited by openshift-ci bot
Loading

@qJkee: This pull request references OCPVE-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from AnnaZivkovic and sadasu October 2, 2023 16:17
@qJkee qJkee changed the title OCPVE-661: bump openshift/api version [WIP] OCPVE-661: bump openshift/api version Oct 3, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci bot
Loading

@qJkee: This pull request references OCPVE-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2023
@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

@qJkee is this openshift/api version bump still required?

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2024
@qJkee
Copy link
Contributor Author

qJkee commented Feb 18, 2024

Hi. Yes, it's needed in order to merge the feature. This is needed for testing and replace will be deleted once api PR lands

@qJkee qJkee changed the title [WIP] OCPVE-661: bump openshift/api version OCPVE-661: bump openshift/api version Feb 28, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
elmiko
elmiko reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic here looks correct to me
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@qJkee qJkee force-pushed the OCPVE-661 branch 3 times, most recently from 6927294 to 8a7a2f7 Compare March 1, 2024 14:16
@qJkee
Copy link
Contributor Author

qJkee commented Mar 1, 2024

/retest

1 similar comment
@qJkee
Copy link
Contributor Author

qJkee commented Mar 2, 2024

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@patrickdillon patrickdillon changed the title OCPVE-661: bump openshift/api version OCPVE-661, OCPBUGS-24415: bump openshift/api version Mar 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024

@qJkee: This pull request references Jira Issue OCPBUGS-24415, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2024
@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 6, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024

@patrickdillon: This pull request references Jira Issue OCPBUGS-24415, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 6, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024

@patrickdillon: This pull request references Jira Issue OCPBUGS-24415, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei March 6, 2024 18:59
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
r4f4
r4f4 reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e245acb into openshift:master Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2024

@qJkee: Jira Issue OCPBUGS-24415: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24415 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn ce72282df41a15ffe4fd95d4e90fd31b70c5ed9a link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn ce72282df41a15ffe4fd95d4e90fd31b70c5ed9a link false /test okd-e2e-aws-ovn
ci/prow/e2e-azurestack 0fa646c1fe534096bba10d2ac0d5ad59e57d8483 link false /test e2e-azurestack
ci/prow/e2e-gcp-ovn 0fa646c1fe534096bba10d2ac0d5ad59e57d8483 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-secureboot 0fa646c1fe534096bba10d2ac0d5ad59e57d8483 link false /test e2e-gcp-secureboot
ci/prow/e2e-gcp-ovn-shared-vpc 0fa646c1fe534096bba10d2ac0d5ad59e57d8483 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-gcp-ovn-xpn 0fa646c1fe534096bba10d2ac0d5ad59e57d8483 link false /test e2e-gcp-ovn-xpn
ci/prow/okd-e2e-aws-ovn-upgrade 2dc1ef8 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-nfv-intel 2dc1ef8 link false /test e2e-openstack-nfv-intel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Mar 9, 2024

Fix included in accepted release 4.16.0-0.nightly-2024-03-09-094904

stbenjam added a commit to stbenjam/installer that referenced this pull request Mar 11, 2024
@stbenjam
Revert "Merge pull request openshift#7546 from qJkee/OCPVE-661"
5652ede 
This reverts commit e245acb, reversing
changes made to 1b99648.
@stbenjam stbenjam mentioned this pull request Mar 11, 2024
Closed
@alebedev87 alebedev87 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@sadasu sadasu Awaiting requested review from sadasu

@elmiko elmiko Awaiting requested review from elmiko

@gpei gpei Awaiting requested review from gpei

+1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@r4f4 r4f4

@elmiko elmiko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@qJkee @openshift-ci-robot @sadasu @elmiko @patrickdillon @openshift-merge-robot @r4f4