Skip to content

Comments

OCPCLOUD-2130: Fix Failuredomains check on manifests test#7617

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
RadekManak:bump-api
Nov 22, 2023
Merged

OCPCLOUD-2130: Fix Failuredomains check on manifests test#7617
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
RadekManak:bump-api

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Oct 20, 2023 •
edited
Loading

CPMS API changed to allow FailureDomains to be a nil value. The openstack manifests tests need to be updated to allow to handle this.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 20, 2023 •
edited by openshift-ci bot
Loading

@RadekManak: This pull request references OCPCLOUD-2130 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

Details

In response to this:

Updates openshift/api to latest version and updates usage of the FailureDomains field now that it is a pointer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from EmilienM and jhixson74 October 20, 2023 14:13
@RadekManak RadekManak force-pushed the bump-api branch 2 times, most recently from 30ec50f to ab7ddc8 Compare October 24, 2023 12:35
@RadekManak
Copy link
Contributor Author

RadekManak commented Oct 24, 2023

/retest golint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

@RadekManak: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-localzones
  • /test altinfra-e2e-azure-ovn
  • /test altinfra-e2e-azure-ovn-resourcegroup
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-alibaba
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-localzones
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-localzones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-ipi-sdn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-nutanix-sdn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack-techpreview
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-agent-compact-ipv4
  • /test okd-scos-e2e-agent-sno-ipv6
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-custom-security-groups
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-fips
  • pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
  • pull-ci-openshift-installer-master-e2e-aws-ovn-localzones
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-localzones
  • pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-installer-master-e2e-azure-ovn
  • pull-ci-openshift-installer-master-e2e-azure-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-e2e-gcp-ovn
  • pull-ci-openshift-installer-master-e2e-gcp-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-gcp-ovn-xpn
  • pull-ci-openshift-installer-master-e2e-gcp-secureboot
  • pull-ci-openshift-installer-master-e2e-openstack-nfv-intel
  • pull-ci-openshift-installer-master-e2e-openstack-ovn
  • pull-ci-openshift-installer-master-e2e-openstack-proxy
  • pull-ci-openshift-installer-master-e2e-openstack-sdn-parallel
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/retest golint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RadekManak
Copy link
Contributor Author

RadekManak commented Oct 24, 2023

/test golint

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2023
@MaysaMacedo
Copy link
Contributor

MaysaMacedo commented Nov 7, 2023

/retest

@MaysaMacedo MaysaMacedo mentioned this pull request Nov 7, 2023
Closed
@RadekManak
Copy link
Contributor Author

RadekManak commented Nov 7, 2023

/retest

@RadekManak
Copy link
Contributor Author

RadekManak commented Nov 7, 2023

All required test passed and non-required look unrelated to me.
/assign @jhixson74

@RadekManak RadekManak changed the title OCPCLOUD-2130: Bump openshift/api OCPCLOUD-2130: Fix Failuredomains check on manifests test Nov 9, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 9, 2023 •
edited by openshift-ci bot
Loading

@RadekManak: This pull request references OCPCLOUD-2130 which is a valid jira issue.

Details

In response to this:

CPMS API changed to allow FailureDomains to be a nil value. The openstack manifests tests need to be updated to allow to handle this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RadekManak
Copy link
Contributor Author

RadekManak commented Nov 9, 2023

The API commit got included elsewhere via override of the manifest test. This PR now only contains the change to the manifest test. I have updated the title and description accordingly.

@EmilienM
Copy link
Member

EmilienM commented Nov 9, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2023

/retest-required

Remaining retests: 0 against base HEAD f60ebb0 and 2 for PR HEAD 60ab60dc1224f9159e96f8836c7e66dbd1ff1985 in total

@r4f4 r4f4 mentioned this pull request Nov 12, 2023
Merged
@r4f4
Copy link
Contributor

r4f4 commented Nov 12, 2023

/override ci/prow/altinfra-e2e-aws-ovn-upi
Not related to this PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2023

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/altinfra-e2e-aws-ovn-upi

Details

In response to this:

/override ci/prow/altinfra-e2e-aws-ovn-upi
Not related to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2023
@RadekManak
Copy link
Contributor Author

RadekManak commented Nov 13, 2023

The API was reverted by #7708. I've added the API changes here again.

@RadekManak
Copy link
Contributor Author

RadekManak commented Nov 14, 2023

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@patrickdillon patrickdillon mentioned this pull request Nov 20, 2023
Merged
r4f4
r4f4 reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 21, 2023

/lgtm
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023

/retest-required

Remaining retests: 0 against base HEAD 9b77312 and 2 for PR HEAD f6a9ce3 in total

@r4f4 r4f4 mentioned this pull request Nov 21, 2023
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023

/retest-required

Remaining retests: 0 against base HEAD 1bacadd and 1 for PR HEAD f6a9ce3 in total

@r4f4 r4f4 mentioned this pull request Nov 21, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023

/retest-required

Remaining retests: 0 against base HEAD 7956adb and 0 for PR HEAD f6a9ce3 in total

@r4f4
Copy link
Contributor

r4f4 commented Nov 21, 2023

/test e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023 •
edited
Loading

@RadekManak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn ab7ddc81d58d5a34bf52abef079d081808575995 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn ab7ddc81d58d5a34bf52abef079d081808575995 link false /test okd-scos-e2e-aws-ovn
ci/prow/altinfra-e2e-aws-custom-security-groups f6a9ce3 link false /test altinfra-e2e-aws-custom-security-groups
ci/prow/altinfra-e2e-aws-ovn-fips f6a9ce3 link false /test altinfra-e2e-aws-ovn-fips
ci/prow/e2e-azurestack f6a9ce3 link false /test e2e-azurestack
ci/prow/altinfra-e2e-aws-ovn-single-node f6a9ce3 link false /test altinfra-e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023

/hold

Revision f6a9ce3 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@r4f4
Copy link
Contributor

r4f4 commented Nov 21, 2023

/test e2e-gcp-ovn

@r4f4
Copy link
Contributor

r4f4 commented Nov 22, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@jhixson74
Copy link
Member

jhixson74 commented Nov 22, 2023

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2023

/retest-required

Remaining retests: 0 against base HEAD dc4d215 and 2 for PR HEAD f6a9ce3 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e4534fe into openshift:master Nov 22, 2023
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202311221354.p0.ge4534fe.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@jhixson74 jhixson74 Awaiting requested review from jhixson74

1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhixson74 jhixson74

@EmilienM EmilienM

@patrickdillon patrickdillon

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@RadekManak @openshift-ci-robot @MaysaMacedo @EmilienM @r4f4 @patrickdillon @jhixson74 @openshift-bot @openshift-merge-robot