CORS-2978: enable AWS SDK Installation through feature gates#7715
CORS-2978: enable AWS SDK Installation through feature gates#7715openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@patrickdillon: This pull request references CORS-2829 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
patrickdillon
force-pushed
the
aws-sdk-fg
branch
from
6fa2f55 to
d229c54
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Don't forget to update the |
patrickdillon
force-pushed
the
aws-sdk-fg
branch
from
d229c54 to
19dc066
Compare
Just pushed a fix |
|
I think it's just missing a |
patrickdillon
force-pushed
the
aws-sdk-fg
branch
from
19dc066 to
de39361
Compare
oh thanks. pushed a fix. |
Meaning it's only used when destroying the bootstrap node during day 0 installation? And not at all in the destroy flow? If that's the case, then you are correct, there should be no hive impact. |
exactly |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
patrickdillon
force-pushed
the
aws-sdk-fg
branch
from
de39361 to
0d2fc19
Compare
|
/hold cancel Fixed the metadata serialization by serializing the feature sets and then reconstructing the feature gate in the destroy code. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@patrickdillon: This pull request references CORS-2829 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Depends on openshift/api#1668 |
openshift-ci
bot
added
the
do-not-merge/hold
patrickdillon
force-pushed
the
aws-sdk-fg
branch
2 times, most recently
from
5491fd0 to
5bc2f10
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/skip |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Depends on openshift/cluster-config-operator#384 |
openshift-merge-robot
added
the
needs-rebase
Includes the feature gates for the cluster. These feature gates can be used for testing bootstrap destroy functionality. Including the feature gates and using them in this manner should not create any issues. Particularly this should not affect hive, as long as this metadata field is not used in the cluster destroy code (as opposed to the bootstrap destroy code it is being used with here). Regardless, it seems like the need for carrying featuregates in the cluster metadata will be short lived while we move to new infrastructure providers. Once these infrastructure providers are considered default, it would be good to consider removing the feature gate in order to keep cluster metadata lightweight.
patrickdillon
force-pushed
the
aws-sdk-fg
branch
from
9721aae to
45dcca5
Compare
openshift-merge-robot
removed
the
needs-rebase
Plumbs through feature gates to the infrastructure provider selector switch. Allows for enabling alternate infrastructure providers through feature gates.
Enables using the SDK alternative infrastructure provider for AWS with a feature gate.
patrickdillon
force-pushed
the
aws-sdk-fg
branch
from
45dcca5 to
dff6f97
Compare
/hold cancel In fact, it is probably better to merge this before openshift/cluster-config-operator#384, so that PR can be adequately tested. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.15.0-202312010731.p0.g065acd5.assembly.stream for distgit ose-installer-altinfra. |
6 participants
Plumbs feature gates through to the infrastructure provider package to enable exposing alternate infrastructure providers through feature gates. Particularly enables the AWS sdk infrastructure provider.
Also includes a fixup of the machine manifests due to the API bump.
This PR plumbs the featuregate into the cluster metadata so that it can be used with the bootstrap destroy code. I know this can be problematic for hive (cc @2uasimojo) when we depend on updates to cluster metadata for destroy code, because cluster metadata is not always present. The functionality added here is only being used in bootstrap destroy code, so I don't think this will negatively affect hive. I think it would be a good idea to remove the feature gate field from the metadata once we have finished implementing the alternate infrastructure providers.