Skip to content

Comments

OPNET-413: deps: update openshift/client-go#7748

Closed
mkowalski wants to merge 1 commit intoopenshift:masterfrom
mkowalski:bump-api-for-opnet
Closed

OPNET-413: deps: update openshift/client-go#7748
mkowalski wants to merge 1 commit intoopenshift:masterfrom
mkowalski:bump-api-for-opnet

Conversation

@mkowalski
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from bfournie and r4f4 November 21, 2023 08:07
@mkowalski mkowalski force-pushed the bump-api-for-opnet branch 2 times, most recently from b416308 to bbff197 Compare November 21, 2023 10:24
@mkowalski mkowalski changed the title deps: update openshift/api deps: update openshift/api and client-go Nov 21, 2023
@r4f4
Copy link
Contributor

r4f4 commented Nov 21, 2023

There are multiple PRs bumping openshift/api atm. The openstack-manifests test needs #7617

@mkowalski
Copy link
Contributor Author

Yeah I have noticed, but also I noticed lots of them are super old and feel stale...

@mkowalski
Copy link
Contributor Author

/hold

Waiting for #7617

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2023
@mkowalski
Copy link
Contributor Author

/unhold

After merging #7617 we still don't have required structure available, meaning that o/api is too old.

The difference is https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L734-L773 (look that BareMetalPlatformSpec is not an empty type) versus installer's version https://github.com/openshift/installer/blob/master/vendor/github.com/openshift/api/config/v1/types_infrastructure.go#L694

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2023
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@mkowalski
Copy link
Contributor Author

mkowalski commented Nov 24, 2023

/retitle OPNET-391: deps: update openshift/api and client-go

@openshift-ci openshift-ci bot changed the title deps: update openshift/api and client-go OPNET-391: deps: update openshift/api and client-go Nov 24, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2023

@mkowalski: This pull request references OPNET-391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor Author

/cc @cybertron

@mkowalski
Copy link
Contributor Author

/retest-required

Both failures unrelated

@mkowalski
Copy link
Contributor Author

/test e2e-gcp-ovn

No builder available

@mkowalski
Copy link
Contributor Author

/test e2e-gcp-ovn

Again no builder available

@cybertron
Copy link
Member

/lgtm

@mkowalski mkowalski changed the title OPNET-391: deps: update openshift/api and client-go OPNET-391: deps: update openshift/client-go Nov 28, 2023
@mkowalski mkowalski changed the title OPNET-391: deps: update openshift/client-go OPNET-413: deps: update openshift/client-go Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2023

@mkowalski: This pull request references OPNET-413 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor Author

/retest-required

@cybertron
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8032847 and 2 for PR HEAD d040896 in total

@mkowalski
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8ee36b7 and 1 for PR HEAD d040896 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 153837a and 0 for PR HEAD d040896 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision d040896 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@mkowalski
Copy link
Contributor Author

/hold cancel

None of the failures was ever related to this change. CI is flaky. As usual?

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 153837a and 2 for PR HEAD d040896 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 88ec5bc and 1 for PR HEAD d040896 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1c0d4dc and 0 for PR HEAD d040896 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision d040896 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@r4f4
Copy link
Contributor

r4f4 commented Nov 30, 2023

/skip

@mkowalski
Copy link
Contributor Author

/hold cancel

e2e-openstack and e2e-azure failed in conformance; not related to this PR

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1c0d4dc and 2 for PR HEAD d040896 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn-virtualmedia d040896 link false /test e2e-metal-ipi-sdn-virtualmedia
ci/prow/e2e-vsphere-zones d040896 link false /test e2e-vsphere-zones
ci/prow/e2e-vsphere-zones-techpreview d040896 link false /test e2e-vsphere-zones-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5dab91f and 1 for PR HEAD d040896 in total

@r4f4
Copy link
Contributor

r4f4 commented Dec 4, 2023

/test altinfra-images

@mkowalski
Copy link
Contributor Author

/close

Feature deferred for 4.16

@openshift-ci openshift-ci bot closed this Dec 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@mkowalski: Closed this PR.

Details

In response to this:

/close

Feature deferred for 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants