Skip to content

Comments

OCPBUGS-23170: Revert #7418 "SPLAT-1141: implement vSphere control plane machinesets"#7708

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
stbenjam:revert-7418-1699640105314
Nov 12, 2023
Merged

OCPBUGS-23170: Revert #7418 "SPLAT-1141: implement vSphere control plane machinesets"#7708
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
stbenjam:revert-7418-1699640105314

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 10, 2023 •
edited
Loading

Reverts #7418 ; tracked by OCPBUGS-23170

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Vsphere techpreview installs are broken since this merged.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test techpreview CI jobs for vsphere on the unrevert, the failure was present in the original PR.

CC: @rvanderp3

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#7418 from rvanderp3/cpms-vsphere…
af6cf28 
…-failure-domain"

This reverts commit f87f13a, reversing
changes made to 973140b.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2023

@stbenjam: This pull request references Jira Issue OCPBUGS-23170, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #7418 ; tracked by OCPBUGS-23170

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Vsphere techpreview installs are broken since this merged.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test techpreview CI jobs for vsphere on the unrevert

CC: @rvanderp3

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 10, 2023
@stbenjam
Copy link
Member Author

stbenjam commented Nov 10, 2023

/override ci/prow/e2e-aws-ovn-shared-vpc-localzones
/override ci/prow/e2e-aws-ovn-imdsv2
/override ci/prow/verify-vendor
/override ci/prow/okd-e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-shared-vpc
/override ci/prow/e2e-aws-ovn
/override ci/prow/tf-fmt
/override ci/prow/e2e-aws-custom-security-groups
/override ci/prow/openstack-manifests
/override ci/prow/okd-verify-codegen
/override ci/prow/okd-scos-verify-codegen
/override ci/prow/govet
/override ci/prow/e2e-azure-ovn
/override ci/prow/e2e-aws-ovn-localzones
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/shellcheck
/override ci/prow/gofmt
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/verify-codegen
/skip
/jira-refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-custom-security-groups, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-imdsv2, ci/prow/e2e-aws-ovn-localzones, ci/prow/e2e-aws-ovn-shared-vpc, ci/prow/e2e-aws-ovn-shared-vpc-localzones, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-azure-ovn, ci/prow/gofmt, ci/prow/govet, ci/prow/okd-e2e-aws-ovn-upgrade, ci/prow/okd-scos-verify-codegen, ci/prow/okd-verify-codegen, ci/prow/openstack-manifests, ci/prow/shellcheck, ci/prow/tf-fmt, ci/prow/verify-codegen, ci/prow/verify-vendor

Details

In response to this:

/override ci/prow/e2e-aws-ovn-shared-vpc-localzones
/override ci/prow/e2e-aws-ovn-imdsv2
/override ci/prow/verify-vendor
/override ci/prow/okd-e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-ovn-shared-vpc
/override ci/prow/e2e-aws-ovn
/override ci/prow/tf-fmt
/override ci/prow/e2e-aws-custom-security-groups
/override ci/prow/openstack-manifests
/override ci/prow/okd-verify-codegen
/override ci/prow/okd-scos-verify-codegen
/override ci/prow/govet
/override ci/prow/e2e-azure-ovn
/override ci/prow/e2e-aws-ovn-localzones
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/shellcheck
/override ci/prow/gofmt
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/verify-codegen
/skip
/jira-refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 10, 2023

Actually think I want this to run through CI since it touched vendoring and it merged a while ago.

/retest-required

@DennisPeriquet
Copy link

DennisPeriquet commented Nov 10, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@stbenjam
Copy link
Member Author

stbenjam commented Nov 10, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2023

@stbenjam: This pull request references Jira Issue OCPBUGS-23170, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 10, 2023
@openshift-ci openshift-ci bot requested a review from gpei November 10, 2023 18:20
@stbenjam
Copy link
Member Author

stbenjam commented Nov 11, 2023

/retest-required
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2023

@stbenjam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-fips af6cf28 link false /test altinfra-e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Nov 12, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 75bca37 into openshift:master Nov 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2023

@stbenjam: Jira Issue OCPBUGS-23170: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23170 has been moved to the MODIFIED state.

Details

In response to this:

Reverts #7418 ; tracked by OCPBUGS-23170

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Vsphere techpreview installs are broken since this merged.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test techpreview CI jobs for vsphere on the unrevert, the failure was present in the original PR.

CC: @rvanderp3

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RadekManak RadekManak mentioned this pull request Nov 13, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 13, 2023

Fix included in accepted release 4.15.0-0.nightly-2023-11-13-174800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@gpei gpei Awaiting requested review from gpei

Assignees

@DennisPeriquet DennisPeriquet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stbenjam @openshift-ci-robot @DennisPeriquet @r4f4 @openshift-merge-robot