Skip to content

OCPBUGS-4038: bootstrap: Enable gatewayd units only on RHCOS #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Oct 23, 2023
Merged

OCPBUGS-4038: bootstrap: Enable gatewayd units only on RHCOS #7580

openshift-ci merged 1 commit into from
Oct 23, 2023

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Oct 11, 2023

Next iteration of #7505

/cc @andfasano @vrutkovs

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 11, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2023

@LorbusChris: This pull request references Jira Issue OCPBUGS-4038, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Next iteration of #7505

/cc @andfasano @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from andfasano, gpei and vrutkovs October 11, 2023 17:01
@LorbusChris LorbusChris mentioned this pull request Oct 11, 2023
Closed
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 11, 2023

/retest

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 12, 2023

Progress, this bootstraps with OCP. OKD not so far..
/retest

@andfasano andfasano mentioned this pull request Oct 12, 2023
Merged
@andfasano
Copy link
Contributor

andfasano commented Oct 12, 2023

/test e2e-agent-compact-ipv4
/test e2e-agent-sno-ipv6

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 12, 2023

This change now still seems to break OKD IPI bootstrap.

Shouldn't the bootstrap host rebase to the OKD OS (SCOS or FCOS+OKD layer) first, and then activate all the services? And only skip them in case of an ABI install?

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 12, 2023

/test okd-scos-e2e-agent-sno-ipv6

@andfasano
Copy link
Contributor

andfasano commented Oct 12, 2023

The aws OKD jobs look broken also in other PRs, so not sure the failures observed here are due the current patch.
Just for a one-off test, openshiftInstallInvoker it could be used to apply the login only when ABI is used (so equal to "agent-installer")

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 13, 2023

/test okd-scos-e2e-aws-ovn

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 13, 2023

/retest

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 13, 2023

okd-scos-e2e-agent-sno-ipv6 passed 👀 IPI bootstrapping on OKD seems broken still though

@andfasano
Copy link
Contributor

andfasano commented Oct 17, 2023

Rechecking aws jobs - from ABI perspective the patch looks fine.

/test okd-scos-e2e-aws-ovn
/test okd-e2e-aws-ovn

@andfasano
Copy link
Contributor

andfasano commented Oct 19, 2023

/approve

@LorbusChris do you still have any point for this patch? As per the latest tests (also here) the failures on okd aws ovn jobs seems related to something else, so it seems to me that we could proceed with this one.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@JM1 JM1 mentioned this pull request Oct 20, 2023
Closed
vrutkovs
vrutkovs approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2023

/retest-required

Remaining retests: 0 against base HEAD 04bfff5 and 2 for PR HEAD 84fbd99 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023 •
edited
Loading

@LorbusChris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 84fbd99 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 84fbd99 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn 84fbd99 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 23, 2023

/test altinfra-images verify-vendor

@openshift-ci openshift-ci bot merged commit bae6c39 into openshift:master Oct 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2023

@LorbusChris: Jira Issue OCPBUGS-4038: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4038 has been moved to the MODIFIED state.

Details

In response to this:

Next iteration of #7505

/cc @andfasano @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor

vrutkovs commented Oct 24, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 24, 2023

@vrutkovs: new pull request created: #7628

Details

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2023
Merged
@LorbusChris LorbusChris mentioned this pull request Oct 24, 2023
Merged
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 24, 2023

@andfasano's change from #7586 was missed here, adding another PR to OCPBUGS-4038: #7629

@LorbusChris LorbusChris mentioned this pull request Oct 26, 2023
Closed
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 27, 2023

Fix included in accepted release 4.15.0-0.nightly-2023-10-27-135451

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@gpei gpei Awaiting requested review from gpei

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LorbusChris @openshift-ci-robot @andfasano @vrutkovs @openshift-cherrypick-robot @openshift-merge-robot