[release-4.14] OCPBUGS-22315: bootstrap: Skip gatewayd units on OKD agent-installer

[LorbusChris]

Cherrypicks of

• OCPBUGS-4038: bootstrap: Enable gatewayd units only on RHCOS #7580
• OCPBUGS-4038: bootstrap: Skip gatewayd units only on OKD agent-installer #7629

[openshift-ci-robot]

@LorbusChris: This pull request references Jira Issue OCPBUGS-22315, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-4038 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-4038 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherrypicks of

• OCPBUGS-4038: bootstrap: Enable gatewayd units only on RHCOS #7580
• OCPBUGS-4038: bootstrap: Skip gatewayd units only on OKD agent-installer #7629

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[LorbusChris]

/cc @andfasano @JM1 @vrutkovs

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@LorbusChris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/aro-unit	efc3fd7	link	true	/test aro-unit
ci/prow/e2e-aws-ovn	efc3fd7	link	true	/test e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn	efc3fd7	link	false	/test okd-e2e-aws-ovn
ci/prow/okd-scos-images	efc3fd7	link	true	/test okd-scos-images
ci/prow/govet	efc3fd7	link	true	/test govet
ci/prow/images	efc3fd7	link	true	/test images
ci/prow/okd-unit	efc3fd7	link	true	/test okd-unit
ci/prow/okd-images	efc3fd7	link	true	/test okd-images
ci/prow/okd-e2e-aws-ovn-upgrade	efc3fd7	link	false	/test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	efc3fd7	link	false	/test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-gcp	efc3fd7	link	false	/test okd-scos-e2e-gcp
ci/prow/e2e-aws-ovn-upgrade	efc3fd7	link	false	/test e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-upgrade	efc3fd7	link	false	/test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-aws-ovn	efc3fd7	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/golint	efc3fd7	link	true	/test golint
ci/prow/e2e-aws-ovn-workers-rhel8	efc3fd7	link	false	/test e2e-aws-ovn-workers-rhel8
ci/prow/okd-scos-unit	efc3fd7	link	false	/test okd-scos-unit
ci/prow/unit	efc3fd7	link	true	/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[LorbusChris]

@andfasano looks like this'll require a backport of #7508

[vrutkovs]

 # github.com/openshift/installer/pkg/asset/ignition/bootstrap
pkg/asset/ignition/bootstrap/common.go:182:42: templateData.Invoker undefined (type *bootstrapTemplateData has no field or method Invoker) 

[LorbusChris]

/hold
checking whether the second commit is really required in #7628

[LorbusChris]

/close

[openshift-ci]

@LorbusChris: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@LorbusChris: This pull request references Jira Issue OCPBUGS-22315. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Cherrypicks of

• OCPBUGS-4038: bootstrap: Enable gatewayd units only on RHCOS #7580
• OCPBUGS-4038: bootstrap: Skip gatewayd units only on OKD agent-installer #7629

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.