Skip to content

Conversation

@andfasano
Copy link
Contributor

Do not merge, just for test

@andfasano
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@openshift-ci openshift-ci bot requested review from AnnaZivkovic and r4f4 October 12, 2023 17:31
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andfasano. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor

r4f4 commented Oct 12, 2023

/uncc

@openshift-ci openshift-ci bot removed the request for review from r4f4 October 12, 2023 18:02
@andfasano
Copy link
Contributor Author

/test okd-e2e-aws-ovn
/test okd-e2e-aws-ovn-upgrade
/test okd-scos-e2e-aws-ovn

@andfasano
Copy link
Contributor Author

@LorbusChris okd aws jobs failed also in this test, relaunching them

@LorbusChris
Copy link
Contributor

The SCOS test did bootstrap successfully though. I'll keep an eye on this

return err
}
if !templateData.IsOKD {
if !templateData.IsOKD || templateData.Invoker != "agent-installer" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it just be this:?

Suggested change
if !templateData.IsOKD || templateData.Invoker != "agent-installer" {
if templateData.Invoker != "agent-installer" {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no actually, nevermind.

@andfasano
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn
/test okd-e2e-aws-ovn

1 similar comment
@andfasano
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn
/test okd-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade fd91c69 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn fd91c69 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn fd91c69 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants