Skip to content

Conversation

@vrutkovs
Copy link
Contributor

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket.

Retry of #6619

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket
@openshift-ci openshift-ci bot requested review from andfasano and sadasu September 20, 2023 08:05
@LorbusChris
Copy link
Contributor

/test okd-images
/test e2e-aws-ovn
/test e2e-agent-compact-ipv4
/test e2e-agent-sno-ipv6
/test okd-e2e-agent-compact-ipv4
/test okd-e2e-agent-sno-ipv6

@LorbusChris
Copy link
Contributor

Infra issue

received unexpected HTTP status: 504 Gateway Time-out

/test e2e-aws-ovn
/test e2e-agent-compact-ipv4
/test e2e-agent-sno-ipv6
/test okd-e2e-agent-compact-ipv4
/test okd-e2e-agent-sno-ipv6

@LorbusChris
Copy link
Contributor

/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade

@LorbusChris
Copy link
Contributor

/test okd-e2e-aws-ovn
/test okd-e2e-aws-ovn-upgrade

@LorbusChris
Copy link
Contributor

/assign @andfasano

@vrutkovs vrutkovs changed the title bootstrap: don't enable gatewayd socket on OKD OCPBUGS-4038: bootstrap: don't enable gatewayd socket on OKD Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-4038, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket.

Retry of #6619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Contributor

/retitle OCPBUGS-4038: bootstrap: don't enable gatewayd socket on OKD

@openshift-ci openshift-ci bot requested a review from gpei September 20, 2023 12:07
@andfasano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@JM1
Copy link
Contributor

JM1 commented Sep 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@LorbusChris
Copy link
Contributor

/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test okd-e2e-agent-compact-ipv4
/test okd-e2e-agent-sno-ipv6

@andfasano
Copy link
Contributor

Note: as mentioned in the previous PR, okd agent jobs are expected to fail. This PR will allow to move further in the right direction for covering abi, but it will not be sufficient. Remaining steps are currenting being addressed in #7484

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 191e070 and 2 for PR HEAD 0506dfc in total

@LorbusChris
Copy link
Contributor

/test okd-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 80f306a and 1 for PR HEAD 0506dfc in total

@vrutkovs
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 010d875 and 0 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0506dfc was retested 3 times: holding

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3a738d8 and 2 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3c3f41c and 1 for PR HEAD 0506dfc in total

@andfasano
Copy link
Contributor

/retest-required

Note: there was an issue affecting the installer images build (related to the openstack.cloud ansible.build), but it should be resolved now

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b6e9f0b and 0 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0506dfc was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-4038, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket.

Retry of #6619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 69cd3d1 and 2 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6a5fd56 and 1 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c926532 and 0 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0506dfc was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@andfasano
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5c653e0 and 2 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 17379ae and 1 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d4ebae5 and 0 for PR HEAD 0506dfc in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0506dfc was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@andfasano
Copy link
Contributor

I've tested e2e-agent-compact-ipv4 locally (with the latest registry.ci.openshift.org/ocp/release:4.15.0-0.ci-2023-10-11-092500) and it went fine, so I'm not sure why it keeps failing in this PR. Relaunching and checking agent-gather.

/retest-required

@LorbusChris
Copy link
Contributor

This seems to break bootstrapping everywhere with IPI: https://prow.ci.openshift.org/pr-history/?org=openshift&repo=installer&pr=7505

It's especially worrying that tests like the e2e-aws-ovn never bootstrap successfully, while that's usually very solid on that platform.

Are we sure AddSystemdUnits() can be invoked safely multiple times with the same path param? Might be worth rewriting this in a way where that's only invoked once with bootstrap/systemd/units for OCP.

@andfasano
Copy link
Contributor

This seems to break bootstrapping everywhere with IPI: https://prow.ci.openshift.org/pr-history/?org=openshift&repo=installer&pr=7505

It's especially worrying that tests like the e2e-aws-ovn never bootstrap successfully, while that's usually very solid on that platform.

Are we sure AddSystemdUnits() can be invoked safely multiple times with the same path param? Might be worth rewriting this in a way where that's only invoked once with bootstrap/systemd/units for OCP.

Nice catch @LorbusChris. In the agent-gather journal I found several ignition failures, and by rechecking the output of create ignition-configs I found duplicated services entries, so it doesn't seem safe to invoke it with the same path param and same config for the non-OKD case (while it was fine for OKD)

@LorbusChris
Copy link
Contributor

Work continues in #7580
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 0506dfc link false /test e2e-agent-sno-ipv6
ci/prow/e2e-aws-ovn-upgrade 0506dfc link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-custom-security-groups 0506dfc link false /test e2e-aws-custom-security-groups
ci/prow/okd-e2e-agent-sno-ipv6 0506dfc link false /test okd-e2e-agent-sno-ipv6
ci/prow/okd-e2e-aws-ovn-upgrade 0506dfc link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 0506dfc link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-agent-compact-ipv4 0506dfc link false /test okd-e2e-agent-compact-ipv4
ci/prow/e2e-aws-ovn 0506dfc link true /test e2e-aws-ovn
ci/prow/e2e-agent-compact-ipv4 0506dfc link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot closed this Oct 11, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-4038. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

FCOS doesn't come with this service, and now assisted installer fails attempting to enable this socket.

Retry of #6619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

@LorbusChris: Closed this PR.

Details

In response to this:

Work continues in #7580
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants