Skip to content

SPLAT-1423: Created CI jobs for CAPI vSphere static IP.#49335

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
vr4manta:SPLAT-1423
Mar 6, 2024
Merged

SPLAT-1423: Created CI jobs for CAPI vSphere static IP.#49335
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
vr4manta:SPLAT-1423

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Feb 28, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2024 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-1423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

SPLAT-1423

Changes

  • Created CI jobs to test vSphere static IP on altinfra for CAPI installer changes

Prerequisites

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vr4manta vr4manta mentioned this pull request Feb 28, 2024
Merged
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 5, 2024

/pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-vsphere-capi-static-ovn

1 similar comment
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

/pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-vsphere-capi-static-ovn

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

/test all

@vr4manta vr4manta marked this pull request as ready for review March 6, 2024 16:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 6, 2024

/lgtm

@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 6, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

/assign @r4f4 @sdodson
Ready for review

@r4f4
Copy link
Contributor

r4f4 commented Mar 6, 2024

Do we really need the openshift-priv changes?

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

Do we really need the openshift-priv changes?

Good question. I only did it to match the other capi config. I can remove it if you think its not needed.

@r4f4
Copy link
Contributor

r4f4 commented Mar 6, 2024

Do we really need the openshift-priv changes?

Good question. I only did it to match the other capi config. I can remove it if you think its not needed.

I don't think it's needed. See https://docs.ci.openshift.org/docs/architecture/private-repositories/#openshift-priv-organization

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

Do we really need the openshift-priv changes?

Good question. I only did it to match the other capi config. I can remove it if you think its not needed.

I don't think it's needed. See https://docs.ci.openshift.org/docs/architecture/private-repositories/#openshift-priv-organization

@r4f4 , I've removed the openshift-priv changes. Thanks!

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

/unassign @sdodson

@r4f4
Copy link
Contributor

r4f4 commented Mar 6, 2024

/pj-rehearse pull-ci-openshift-installer-master-altinfra-e2e-vsphere-capi-static-ovn pull-ci-openshift-installer-release-4.15-altinfra-e2e-vsphere-static-ovn

@r4f4
Copy link
Contributor

r4f4 commented Mar 6, 2024

No provider is defined for the vsphere altinfra in 4.15:

level=info msg=Creating infrastructure resources...
panic: not implemented
goroutine 1 [running]:
github.com/openshift/installer/pkg/infrastructure/platform.ProviderForPlatform({0x8e392a5?, 0x4?}, {0x8ef7819?, 0x24?})

So maybe we can drop the 4.15 change?

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

No provider is defined for the vsphere altinfra in 4.15:

level=info msg=Creating infrastructure resources...
panic: not implemented
goroutine 1 [running]:
github.com/openshift/installer/pkg/infrastructure/platform.ProviderForPlatform({0x8e392a5?, 0x4?}, {0x8ef7819?, 0x24?})

So maybe we can drop the 4.15 change?

yeah, i noticed bot added it from main file. I can remove this. static ip was in 4.15, but not for altinfra. Let me make that change real quick.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-altinfra-e2e-vsphere-capi-static-ovn openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-vsphere-capi-static-ovn openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-vsphere-capi-static-ovn openshift/installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Contributor

r4f4 commented Mar 6, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/release-4.15/altinfra-e2e-vsphere-static-ovn 486a89b link unknown /pj-rehearse pull-ci-openshift-installer-release-4.15-altinfra-e2e-vsphere-static-ovn
ci/rehearse/openshift/installer/release-4.16/altinfra-e2e-vsphere-capi-static-ovn cd1e1d0 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-vsphere-capi-static-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

jcpowermac commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, r4f4, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 6, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c5c094c into openshift:master Mar 6, 2024
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@vr4manta @memodi
Created CI jobs for CAPI vSphere static IP. (openshift#49335)
79b0cdb
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@vr4manta @BradLugo
Created CI jobs for CAPI vSphere static IP. (openshift#49335)
3468556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@r4f4 r4f4

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vr4manta @openshift-ci-robot @jcpowermac @r4f4 @sdodson