Skip to content

SPLAT-1141: implement vSphere control plane machinesets#7418

Merged
openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
rvanderp3:cpms-vsphere-failure-domain
Nov 8, 2023
Merged

SPLAT-1141: implement vSphere control plane machinesets#7418
openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
rvanderp3:cpms-vsphere-failure-domain

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Aug 14, 2023 •
edited
Loading

Implements failure domain aware control plane machinesets for vSphere. The control plane machineset will only be set to active when the TechPreviewNoUpgrade feature set is enabled.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 14, 2023 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1141 which is a valid jira issue.

Details

In response to this:

Depends on openshift/api#1539

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 marked this pull request as draft August 14, 2023 17:02
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Aug 14, 2023

/test e2e-vsphere-ovn

@openshift-ci openshift-ci bot requested review from patrickdillon and sadasu August 14, 2023 17:07
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 2 times, most recently from bc0310c to 7034865 Compare August 14, 2023 20:19
@rvanderp3 rvanderp3 changed the title WIP: SPLAT-1141: add template to vSphere failure domain topology WIP: SPLAT-1141: implement vSphere control plane machinesets Aug 15, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 23d3d05 to 64024e7 Compare August 15, 2023 16:25
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from ed823ad to c00d4fd Compare October 18, 2023 19:33
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from c00d4fd to ddde2f2 Compare October 18, 2023 19:35
@rvanderp3 rvanderp3 marked this pull request as ready for review October 18, 2023 19:45
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 18, 2023

leaving hold on until API merges

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 18, 2023

/test all

@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from ddde2f2 to 82d0835 Compare October 24, 2023 13:01
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 82d0835 to bac52de Compare October 24, 2023 13:08
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2023
@rvanderp3 rvanderp3 changed the title WIP: SPLAT-1141: implement vSphere control plane machinesets SPLAT-1141: implement vSphere control plane machinesets Oct 24, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2023
@jcpowermac
Copy link
Contributor

jcpowermac commented Oct 24, 2023

/lgtm

@rvanderp3 rvanderp3 mentioned this pull request Oct 24, 2023
Merged
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 24, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from cc819f2 to 78a4260 Compare October 24, 2023 20:21
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Nov 3, 2023

/assign @patrickdillon

@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 6, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2023

/retest-required

Remaining retests: 0 against base HEAD b36d7c2 and 2 for PR HEAD 9a7ec63 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2023

/retest-required

Remaining retests: 0 against base HEAD 9ff8208 and 1 for PR HEAD 9a7ec63 in total

@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 6, 2023

4.15 seems unhappy

/hold cancel
/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2023

/retest-required

Remaining retests: 0 against base HEAD e7b2f51 and 0 for PR HEAD 9a7ec63 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2023

/hold

Revision 9a7ec63 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 7, 2023

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 7, 2023

/override ci/prow/openstack-manifests

@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 7, 2023

/skip

@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 7, 2023

/override ci/prow/openstack-manifests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/openstack-manifests

Details

In response to this:

/override ci/prow/openstack-manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/openstack-manifests

Details

In response to this:

/override ci/prow/openstack-manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2023

/retest-required

Remaining retests: 0 against base HEAD 2596e5d and 2 for PR HEAD 9a7ec63 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2023

/retest-required

Remaining retests: 0 against base HEAD 973140b and 1 for PR HEAD 9a7ec63 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023 •
edited
Loading

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 78a4260f51ba1de61150f3ff3a738894726f7af7 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 78a4260f51ba1de61150f3ff3a738894726f7af7 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-zones-techpreview 9a7ec63 link false /test e2e-vsphere-zones-techpreview
ci/prow/okd-e2e-aws-ovn-upgrade 9a7ec63 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-xpn 9a7ec63 link false /test e2e-gcp-ovn-xpn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sadasu
Copy link
Contributor

sadasu commented Nov 8, 2023

/override ci/prow/openstack-manifests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/openstack-manifests

Details

In response to this:

/override ci/prow/openstack-manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f87f13a into openshift:master Nov 8, 2023
@stbenjam
Copy link
Member

stbenjam commented Nov 10, 2023 •
edited
Loading

This broke techpreview jobs -- and it showed up in presubmits signal here: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7418/pull-ci-openshift-installer-master-e2e-vsphere-zones-techpreview/1720102264128933888

@stbenjam stbenjam mentioned this pull request Nov 10, 2023
Merged
stbenjam added a commit to stbenjam/installer that referenced this pull request Nov 10, 2023
@stbenjam
Revert "Merge pull request openshift#7418 from rvanderp3/cpms-vsphere…
af6cf28 
…-failure-domain"

This reverts commit f87f13a, reversing
changes made to 973140b.
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Nov 10, 2023

This broke techpreview jobs -- and it showed up in presubmits signal here: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7418/pull-ci-openshift-installer-master-e2e-vsphere-zones-techpreview/1720102264128933888

Yep, this was my error. We needed this PR to merge for openshift/cluster-control-plane-machine-set-operator#228 . This presubmit was failing because that PR has not merged. We'll work to get that PR merged first before we revert this PR.

openshift-merge-bot bot added a commit that referenced this pull request Nov 12, 2023
@openshift-merge-bot
Merge pull request #7708 from stbenjam/revert-7418-1699640105314
75bca37 
OCPBUGS-23170: Revert #7418 "SPLAT-1141: implement vSphere control plane machinesets"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@jhixson74 jhixson74

@patrickdillon patrickdillon

@jcpowermac jcpowermac

@rna-afk rna-afk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@rvanderp3 @openshift-ci-robot @jcpowermac @rna-afk @patrickdillon @sadasu @stbenjam @jhixson74 @openshift-merge-robot @vr4manta