OCPBUGS-7015: vsphere, nutanix survey: relax vip in machine cidr #6967
Conversation
This commit removes validation to ensure the ingress and API vips are in the default machine network cidr. This validation was added to all on-prem platforms. Installs have worked without this validation since the release of openshift 4 and the new requirements seems to be causing user issues. So we are relaxing the validation to be consistent with previous releases and because there is not a clear need for the validation.
openshift-ci-robot
added
jira/valid-reference
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-7015, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-7015, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rvanderp3 added this validation in ocpbugs-881. The motivation for that fix was in order to make the TUI consisitent with the install config validation. #6915 removed the install config validation for the VIP in machine cidr check. This PR is a follow up. My original PR missed removing this validation from the survey. |
|
Rich's PR also added validation for ovirt. My PR is only removing validation for vsphere and nutanix based on the slack conversation. If we think ovirt should be relaxed as well, please LMK. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/skip |
|
/retest |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-vsphere-ovn Single e2e test failure, looks like a flake. Certainly not related to this pr. |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: Jira Issue OCPBUGS-7015: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-7015 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.13 |
|
@patrickdillon: new pull request created: #7107 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This commit removes validation to ensure the ingress and API vips are in the default machine network cidr. This validation was added to all on-prem platforms. Installs have worked without this validation since the release of openshift 4 and the new requirements seems to be causing user issues. So we are relaxing the validation to be consistent with previous releases and because there is not a clear need for the validation.